Skip to content

[IR] Support SelectRowsType - #55041

Merged
zhangbo9674 merged 7 commits into
PaddlePaddle:developfrom
zhangbo9674:dev/support_select_rows
Jul 3, 2023
Merged

zhangbo9674 merged 7 commits into
PaddlePaddle:developfrom
zhangbo9674:dev/support_select_rows

Conversation

@zhangbo9674

Copy link
Copy Markdown
Contributor

PR types

New features

PR changes

Others

Description

支持 SelectRowsType、添加 embedding_grad_sparse 算子

Other

Pcard-67164

@paddle-bot

paddle-bot Bot commented Jun 30, 2023

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

using ParamKey =
std::tuple<ir::Type, phi::DDim, phi::DataLayout, phi::LoD, size_t>;

SelectedRowsTypeStorage(ir::Type dtype,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const & 替换 「值传递」?

/// \brief Each derived TypeStorage must define a Construct method, which
/// StorageManager uses to construct a derived TypeStorage.
///
static SelectedRowsTypeStorage* Construct(ParamKey key) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前的PR已经统一这里了,应该都是const &

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, tks!

@Aurelius84 Aurelius84 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangbo9674
zhangbo9674 merged commit c6bd9fb into PaddlePaddle:develop Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants