[BugFix] Fix root logger configuration being modified by PaddleOCR imports - #18247
Open
nandanadileep wants to merge 2 commits into
Open
nandanadileep wants to merge 2 commits into
nandanadileep wants to merge 2 commits into
Conversation
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Importing
paddleocrtriggers dependency imports (e.g.,paddlex,paddle) that may modify the root logger's level or handlers. This causes issues where users who configure logging *before* importing PaddleOCR find their log output silenced after the import.Modifications
paddleocr/__init__.py: Save the root logger's level and handler list before module imports, then restore them after all imports complete. This ensures PaddleOCR does not interfere with the calling application's logging configuration.tests/unit/test_logging_restore.py: Added unit tests validating the save/restore mechanism handles level changes, handler additions, handler removals, and the no-op case.Usage or Command
N/A
Accuracy Tests
N/A - logging change only, no model accuracy impact.
Checklist
pre-commitbefore commit.releasebranch, make sure the PR has been submitted to themainbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.Closes #14955