fix: respect ratio_list sampling in MultiScaleDataSet - #18345
Open
lzy494177-byte wants to merge 1 commit into
Open
lzy494177-byte wants to merge 1 commit into
lzy494177-byte wants to merge 1 commit into
Conversation
lzy494177-byte
force-pushed
the
fix/multiscale-ratio-sampling
branch
from
September 4, 2026 16:55
f58d73a to
47f5175
Compare
lzy494177-byte
force-pushed
the
fix/multiscale-ratio-sampling
branch
from
September 4, 2026 17:00
47f5175 to
dcc033d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MultiScaleDataSetdoes not correctly respect the_index_mapgenerated by
SimpleDataSetwhenratio_listcontains values below 1.0.For
ds_width=False, sample indices are resolved throughdata_idx_order_listinstead of_index_map.For
ds_width=True,wh_ratio_sortis built from the full datasetinstead of the ratio-sampled subset.
After
reset_data_lines()changes the sampled subset, the cachedwidth-aware state in
MultiScaleSamplercan also become stale.Example
Given two label files:
ratio_list = [0.5, 0.5]Expected:
Although
_index_mapcontains the correct sampled indices,MultiScaleDataSetmay access samples outside that subset.For width-separated samples, this can result in accessing
100 samples from A and 0 samples from B.
Fix
MultiScaleDataSetindices through_index_map.MultiScaleSamplerbatches after dataset reset.ds_width=Falseandds_width=True,including epoch reset behavior.
Tests
Result:
All modified files also pass
pre-commit.