fix: apply TypeScript SDK timeouts to response bodies - #18356
Open
Hanabi9248 wants to merge 3 commits into
Open
Hanabi9248 wants to merge 3 commits into
Hanabi9248 wants to merge 3 commits into
Conversation
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript SDK clears its request timer and removes the caller abort listener as soon as
fetchreceives response headers. Reading the body happens afterwards, so a slow body can outliverequestTimeout, and cancellation after headers is ignored.Keep JSON, JSONL, resource, and HTTP error body reads inside the request deadline, with cleanup after consumption. Preserve the existing API error types and caller-provided abort reason.
Five regression cases use a local HTTP server that sends headers immediately and delays the body. They cover successful and error status responses, JSONL, binary resources, and caller cancellation. All five fail before the fix.
Validation on Windows with Node 24.19.0:
npm run prepublishOnlyinapi_sdk/typescriptpasses (TypeScript check, ESM/CJS/declaration builds, and all 46 SDK tests). Hosted OCR inference and other language SDK suites were not run. Please squash on merge.