Skip to content

【Hackathon 8th No.7】Python版本适配 3 - #3969

Merged
zxcd merged 6 commits into
PaddlePaddle:developfrom
Liyulingyue:patch-11
Jan 21, 2025
Merged

【Hackathon 8th No.7】Python版本适配 3#3969
zxcd merged 6 commits into
PaddlePaddle:developfrom
Liyulingyue:patch-11

Conversation

@Liyulingyue

@Liyulingyue Liyulingyue commented Jan 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

Others

Describe

移除对部分依赖库的版本限制

基于 https://github.com/timmahrt/praatIO/blob/main/UPGRADING.md#version-5-to-6-migration

  • Instead of using with Textgrid.tierDict directly, please use Textgrid.addTier(), Textgrid.getTier(), Textgrid.removeTier(), and Textgrid.renameTier()
  • TextgridTier.entryList was renamed to TextgridTier.entries and made read only. Please use TextgridTier.insertEntry() and TextgridTier.deleteEntry() if you need to modify it.

@mergify mergify Bot added the Installation label Jan 16, 2025
@luotao1 luotao1 mentioned this pull request Jan 16, 2025
Closed
zxcd
zxcd reviewed Jan 16, 2025
View reviewed changes
Comment thread setup.py Outdated
"ppdiffusers>=0.9.0",
"paddlespeech_feat",
"praatio>=5.0.0, <=5.1.1",
"praatio",

@zxcd zxcd Jan 16, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test if MFA can work

Comment thread setup.py
"prettytable",
"pydantic>=1.10.14, <2.0",
"pypinyin<=0.44.0",
"pydantic",

@zxcd zxcd Jan 16, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check #3715 whether work

@Liyulingyue Liyulingyue Jan 16, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix with Optional[str]

@mergify mergify Bot added the Server label Jan 16, 2025
Liyulingyue
Liyulingyue commented Jan 16, 2025
View reviewed changes
Comment thread setup.py Outdated
Liyulingyue
Liyulingyue commented Jan 16, 2025
View reviewed changes
Comment thread setup.py Outdated
zxcd
zxcd reviewed Jan 17, 2025
View reviewed changes
Comment thread examples/other/g2p/get_g2p_data.py Outdated
Liyulingyue
Liyulingyue commented Jan 17, 2025
View reviewed changes
Comment thread examples/other/g2p/get_g2p_data.py Outdated
zxcd
zxcd approved these changes Jan 21, 2025
View reviewed changes

@zxcd zxcd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxcd
zxcd merged commit 85de840 into PaddlePaddle:develop Jan 21, 2025
@GreatV GreatV mentioned this pull request Feb 28, 2025
Closed
@luotao1 luotao1 mentioned this pull request Mar 5, 2025
Closed
@Liyulingyue
Liyulingyue deleted the patch-11 branch March 5, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zxcd zxcd zxcd approved these changes

Assignees

No one assigned

Labels

contributor Example Installation Server T2S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Liyulingyue @zxcd