Fix double encoding path for http4s client #3620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2025 19:00
Philippus
approved these changes
Sep 10, 2025
|
@igor-vovk Do you have some time to take a look? I think you use http4s. |
|
Unfortunately I can't test it since I'm not using it anymore in my own projects, but the PR is LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using http4s client I found that id is stored incorrectly in ElasticSearch in case then it contains special characters. The trouble was in final resulting URL.
ElasticUrlEncoderinIndexHandlerencoded path and convertororg.http4s.Segment.applyinRequestResponseConverters. elasticRequestToHttp4sRequestalso encoded path before sending request.