Skip to content

Overwriting mixin properties  #1873

Closed
Closed
Overwriting mixin properties #1873
Assignees
sorvell
Labels
p1

Description

@Pupix
Pupix
opened on Jun 15, 2015

Hello! I am trying to overwrite a property coming from a CSS mixing, but the way Polymer handles the variables makes it impossible to do so (without using "!important").

<style>
    .foo {
        @apply(--paper-font-caption)
        white-space: normal;
    }
</style>

The expected result would be to have "white-space: normal" applied on top of the one provided by paper-styles, however that's not the case.

Do I have to rewrite the entire mixing just to change one property or is there an alternative way?

Cheers.

Activity

  1. sorvell
    added
    p1
    on Jun 16, 2015
  2. sorvell
    self-assigned this
    on Jun 16, 2015

  3. sorvell commented on Jun 16, 2015

    @sorvell
    sorvell
    on Jun 16, 2015
    Contributor

    This is due to the way that Polymer separates static styles from styles which contain custom properties. This use case is reasonable and our approach needs to be modified slightly to support this better.

    We will probably not separate custom properties css from static css within rules that contain properties.

  4. Pupix commented on Jun 16, 2015

    @Pupix
    Pupix
    on Jun 16, 2015
    Author

    Thanks for the response. Will wait for an update then.

  5. sorvell commented on Aug 21, 2015

    @sorvell
    sorvell
    on Aug 21, 2015
    Contributor

    This issue also leads to specificity issues when combining static and custom property rules.

  6. robrez commented on Oct 28, 2015

    @robrez
    robrez
    on Oct 28, 2015

    👍

  7. jmcgdz commented on Oct 28, 2015

    @jmcgdz
    jmcgdz
    on Oct 28, 2015

    👍

  8. nazar-pc commented on Oct 29, 2015

    @nazar-pc
    nazar-pc
    on Oct 29, 2015
    Contributor

    @Pupix, can you provide complete test case? I guess this might be either already fixed by #2642 or I can try to extend PR to cover this case as well and add corresponding test case.

  9. robrez commented on Oct 29, 2015

    @robrez
    robrez
    on Oct 29, 2015

    @nazar-pc Here's a jsbin that, i think, demonstrates the issue:

    https://jsbin.com/kefuzi/edit?html,output

  10. nazar-pc commented on Oct 29, 2015

    @nazar-pc
    nazar-pc
    on Oct 29, 2015
    Contributor

    OK, here is easier to understand example: https://jsbin.com/xupufudivu/1/edit

  11. nazar-pc commented on Oct 29, 2015

    @nazar-pc
    nazar-pc
    on Oct 29, 2015
    Contributor

    Seems to be different area than covered in #2642, but I'll take a look on this as well.

  12. nazar-pc
    added a commit that references this issue on Oct 29, 2015

    Fix for overriding mixin properties, fixes Polymer#1873

    092a9d0

  13. nazar-pc commented on Oct 29, 2015

    @nazar-pc
    nazar-pc
    on Oct 29, 2015
    Contributor

    #2642 now fixes this issue as well.

  14. nazar-pc
    added a commit that references this issue on Nov 4, 2015

    Fix for overriding mixin properties, fixes Polymer#1873

    3ea889e
  15. nazar-pc
    added a commit that references this issue on Nov 13, 2015

    Fix for incorrect CSS selectors specificity as reported in Polymer#2531

    fd57784
  16. dfreedm
    closed this as completedin fd57784on Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

p1

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions