Skip to content

0.8 x style - #1482

Merged
kevinpschaaf merged 9 commits into
0.8-previewfrom
0.8-x-style
May 4, 2015
Merged

0.8 x style#1482
kevinpschaaf merged 9 commits into
0.8-previewfrom
0.8-x-style

Conversation

@sorvell

@sorvell sorvell commented May 4, 2015

Copy link
Copy Markdown
Contributor

  • rename x-style --> custom-style

  • rename mixin --> @apply

  • support :root selector

  • variable defaultsvar(--a, red)

  • fixes bug: c--foo: is seen as a custom property

  • consume variable, mixin inside mixin

    --foo: {
  color: var(--my-color);
  @apply(--my-theme);
};

  • consume custom properties in custom-style (short-term workaround to support @extend-use case style sharing

sorvell and others added 8 commits April 29, 2015 15:20
@sorvell
x-scope styling fixes.
3c9ebc3
@sorvell
ownerRoot fix for subtree add/remove
918ba51
@sorvell
slight optimization to resetting ownerShadyRoot info
1dc5d8b
Steven Orvell
Merge branch '0.8-preview' into 0.8-x-style
ca30c0e
Steven Orvell
change x-style to custom-style; apply properties used in custom-style
bfed71b
Steven Orvell
Merge branch '0.8-preview' into 0.8-x-style
b5646b0
Steven Orvell
styling factoring:
ec27fe8 
* custom properties supports defaults, e.g. var(--a, --b);
* x-style renamed to custom-style
* custom-style supports defining properties at :root; also support using properties in document
* mixins support consuming properties and mixins inside them.
Steven Orvell
Merge branch '0.8-preview' into 0.8-x-style
ffe5a2f
@kevinpschaaf

kevinpschaaf commented May 4, 2015

Copy link
Copy Markdown
Member

LGTM. More optimizations and refactoring discussed for future commits.

kevinpschaaf added a commit that referenced this pull request May 4, 2015
@kevinpschaaf
Merge pull request #1482 from Polymer/0.8-x-style
1976ad0 
0.8 x style
@kevinpschaaf
kevinpschaaf merged commit 1976ad0 into 0.8-preview May 4, 2015
@kevinpschaaf
kevinpschaaf deleted the 0.8-x-style branch May 4, 2015 22:24
@arthurevans

arthurevans commented May 5, 2015

Copy link
Copy Markdown

What's a :root when it's at home?

@sorvell

sorvell commented May 5, 2015

Copy link
Copy Markdown
Contributor Author

We'll add info to the primer.

It's just this (http://www.w3schools.com/cssref/sel_root.asp) and it's a
way to define custom properties for the entire root scope (where previous
we used '*')

On Mon, May 4, 2015 at 5:05 PM, Arthur Evans notifications@github.com
wrote:

What's a :root when it's at home?

—
Reply to this email directly or view it on GitHub
#1482 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sorvell @kevinpschaaf @arthurevans @googlebot