Added decompositions for focal lengths from F #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlarsson
requested changes
Jul 29, 2024
Collaborator
vlarsson
left a comment
There was a problem hiding this comment.
Looks great! Maybe we should move decompositions to /misc/ ?
* bump version * add decompositions to README
Contributor
Author
|
I moved the files to misc and added a part about decompositions into the README, also bumped the version to 2.0.3. |
pablospe
reviewed
Jul 29, 2024
| misc/essential.cc | ||
| misc/re3q3.cc | ||
| misc/colmap_models.cc | ||
| misc/decompositions.cc |
Collaborator
There was a problem hiding this comment.
nit: there are some extra spaces here, right?
Contributor
Author
There was a problem hiding this comment.
Ah yes, my IDE always adds those. Forgot to remove them after moving the files to misc/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added decompositions as mentioned in #89
There are two methods:
focals_from_fundamentalusing Bougnoux formulafocals_from_fundamental_iterativeusing our recent iterative methodBoth also have python bindings.
They both return two Camera structs. The iterative method also takes the prior camera info as the Camera struct and also outputs the number of iterations. The baseline method takes as input also the principal points of the two cameras.
I tested them on Phototourism with SP+SG matches:
And the same setup on Aachen Day-Night v1.1:
