CRITICAL: The bottom sheet never reflects updated episode state

EpisodeListSheet is a StatelessWidget fed one-shot snapshots (episodeList, isLoading, queryTimeout) and is not wrapped in Observer. showAdaptiveBottomSheet -> showModalBottomSheet builds this widget inside its own route, so setState(() {}) in retryLoadEpisodes (line 240) rebuilds only _InfoPageState, not the sheet.

Consequences:

• Tapping 重试 refetches the data but the failure UI stays on screen until the user closes and reopens the sheet.
• Opening the sheet while the initState preload is still in flight leaves the skeleton frozen forever.
• queryBangumiEpisodesByID replaces the list instance (episodeList = ObservableList<EpisodeInfo>.of(list), info_controller.dart:237), so even the reference captured at line 252 can never see the new items.

Wrap the sheet body in Observer (the pattern used in source_sheet.dart:497 and episode_comments_sheet.dart:112) or make EpisodeListSheet stateful and own the fetch.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

CRITICAL: MobX codegen is stale, so these new @observable fields are not reactive

lib/pages/info/info_controller.g.dart is tracked in the repo but was not regenerated in this PR: _$InfoController still stops at staffList (info_controller.g.dart:93-118) and contains no atoms for episodeList, episodesIsLoading, episodesQueryTimeout or episodesIsEmpty.

Without generated getter/setter overrides these are ordinary fields: reads are never tracked and writes never notify, so no Observer (including the ones at info_page.dart:447/498) can react to episode state. This compiles and flutter analyze stays clean, which makes the breakage silent.

Run dart run build_runner build --delete-conflicting-outputs and commit the regenerated info_controller.g.dart.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

WARNING: A partially failed pagination is reported as success

BangumiApi.getBangumiEpisodesByID wraps the whole do/while pagination loop in a single try/catch and returns whatever it accumulated (bangumi_api.dart:391-422). If page 1 succeeds but page 2 fails (network drop, rate limit, jsonData['total'] as int? cast error on an unexpected payload), this method receives a non-empty but silently truncated list — e.g. only the first 100 episodes of a 300-episode subject — and treats it as a successful load with no error state and no retry affordance.

Have the API surface the failure (rethrow, or return a result object with a partial/failed flag) so the UI can distinguish complete data from truncated data.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

WARNING: Legitimately empty results are shown as a failure, and episodesIsEmpty is dead state

Nothing ever sets episodesIsEmpty = true (it is only set to false at lines 69 and 234), so the empty-state branch in episode_list_sheet.dart:181-188 is unreachable dead code, and the isEmpty prop threaded through info_page.dart:255 is always false.

More importantly, a subject that genuinely has zero episode records (unaired series, some movies) is classified as episodesQueryTimeout = true and rendered as 集数获取失败 with a retry button that can never succeed. episode_comments_sheet.dart:239 treats the same empty response as a not-found case (未找到分集列表) instead of an error — please align, or make the API distinguish failure from emptiness.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

WARNING: Clearing the loading flag breaks the re-entrancy guard and allows cross-subject data leakage

clearEpisodes() is called from initState (info_page.dart:210) and dispose (info_page.dart:325). Resetting episodesIsLoading = false while a request is still in flight defeats the guard at line 229, so a second concurrent fetch can start and the two responses resolve last-writer-wins.

There is also no request/subject token: an in-flight fetch that completes after the page is disposed still writes episodeList and episodesQueryTimeout, so the next subject's detail page can display the previous subject's episode list (the controller instance is provided per route, but the pending future outlives the widget).

Capture the requested id and discard the result when it no longer matches bangumiItem.id, and don't reset the in-flight flag in clearEpisodes().

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

WARNING: Fixed 168px button row will overflow on compact phone widths

The card's outer Row (line 141) has a single inflexible child (SizedBox(width: 16), line 166) plus two loose Flexible children (the poster and this info column; the vote chart is skipped below 600dp, lines 275-279). Flex splits the remaining space by flex factor regardless of the poster being height-bound, so this column gets about (screenWidth - 32 - 16) / 2 (the card is padded with fromLTRB(16, ..., 16, 0) at info_page.dart:470).

This Row is MainAxisSize.min with hard-coded children of 120 + 8 + 40 = 168px, so it cannot shrink and only fits when screen width is roughly >= 384dp: 360dp (very common on Android) overflows by ~12px and 320dp by ~32px. Previously the slot needed only 120px, so this is a regression. Wrap the collect button in Flexible/Expanded, or use Wrap, instead of fixed widths.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

WARNING: Full episode list is prefetched on every detail-page open

This runs unconditionally in initState, and getBangumiEpisodesByID pages 100 records at a time until total (bangumi_api.dart:391-422). Opening any subject therefore fires 1..N sequential HTTP requests and parses potentially thousands of models even when the user never taps the new button, competing with the info/comments/image loads during the page-entry animation, and with no caching or cancellation.

Load lazily on first sheet open (as episode_comments_sheet.dart:229 does for an explicit gesture) and keep the result for the lifetime of the page.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

SUGGESTION: Icon-only button has no tooltip or semantics label

_EpisodeListButton renders only Icons.video_collection_rounded, so hover users and screen readers get no indication of what it does. The adjacent collect button sets tooltip: (collect_button.dart:115) — do the same here, e.g. tooltip: '集数详情'.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

SUGGESTION: bangumiItem is a required parameter that is never read

Nothing in this widget uses bangumiItem, yet it is required in the constructor (line 14) and forces info_page.dart:251 to pass it. The analyzer does not flag unused public fields, so this dead coupling to BangumiItem will silently persist. Remove it, or use it (e.g. show the subject title in the sheet header).

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

SUGGESTION: retryLoadEpisodes is byte-identical to loadEpisodes

Lines 233-238 and 240-245 are the same code; keep one method. Note also that the setState(() {}) in both is pure churn: build() reads no episode state, so it rebuilds the entire page (including the blurred header image subtree) without changing any output — the sheet, which is what needs updating, is on a separate route.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

WARNING: Episode type map is shifted by one for types 5 and 6

Bangumi's EpType enum is 0 = 本篇, 1 = 特别篇, 2 = OP, 3 = ED, 4 = 预告/宣传/广告 (PV/CM), 5 = MAD, 6 = 其他 — there is no distinct "CM" type. This map assigns 5 -> 'cm' / '广告' and 6 -> 'mad' / 'MAD', so real type-5 MAD episodes are labelled 广告 and type-6 其他 episodes are labelled MAD. The mislabeling shows up both in the new sheet section headers (typeSectionTitles) and in the player UI via readType() (lib/pages/player/episode_comments_sheet.dart:175).

Map 5 to MAD and let 6 fall through to otherSectionTitle (or map it explicitly to 其他).

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

WARNING: episode > 0 silently drops the episode number for sort == 0

EpisodeInfo.fromJson defaults a missing sort to 0 (line 19), and Bangumi legitimately returns sort == 0 for prologue / 第0話 entries, so this branch cannot distinguish "no sort" from "sort is zero". Those rows now render as a bare EP: instead of EP0:, and if a section contains more than one of them every row shows an identical label with no way to tell the episodes apart.

Track sort presence explicitly (nullable sort, or a hasSort flag set in fromJson) instead of overloading 0.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

SUGGESTION: Changing the readType() fallback leaks into the player UI

readType() previously returned '' for unmapped types; it now returns 'other'. The pre-existing consumer formats '${readType()}.${episode}' (lib/pages/player/episode_comments_sheet.dart:175, :182, :183, :266), so the player header and episode picker change from .12 to OTHER.12/other.12 for unknown types — a side effect of a model-level change that this PR does not otherwise touch.

Keep the raw abbreviation empty for unknown types and apply the other fallback in the new sheet only, or update the player call sites deliberately.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

SUGGESTION: #$type puts a type id where an episode number is expected

Every other prefix in this slot ends with an episode number, so an unknown type 9 renders #9: which reads as "episode 9". It also discards a present sort, so all unknown-type rows inside one section get the identical label.

Including the sort (e.g. #<sort> when available) keeps rows distinguishable and avoids implying the value is a type id.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

WARNING: Non-shrink-wrapping CustomScrollView makes the sheet height jump and over-tall

CustomScrollView defaults to shrinkWrap: false, and a viewport under Flexible (loose constraints, bounded by adaptiveBottomSheetConstraints' maxHeight = 0.75 * screenHeight, 0.9 in compact landscape) always takes the full available height. The skeleton branch at line 108 uses SingleChildScrollView, which does size to its child, so the sheet opens short and then snaps to ~75% of the screen when data arrives; a movie with one or two records renders a mostly empty sheet. The previous implementation used ListView(shrinkWrap: true) and sized to content.

Use CustomScrollView(shrinkWrap: true) (lazy sliver building is preserved) or give all four states a consistent height.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

SUGGESTION: Two unmapped types produce two adjacent sections both titled 其它

Grouping is keyed by the raw type value while the title falls back to the shared EpisodeInfo.otherSectionTitle, so a subject that returns two different unmapped types (e.g. 7 and 8) renders duplicate 其它 (n) headers with no way to tell them apart.

Bucket all unmapped types into a single group, or append the raw type to the fallback title.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

SUGGESTION: Doc comment contradicts the only call site, and this leaves the flags inconsistent

The comment says the method is for resetting display data "sheet 关闭后", but nothing runs on sheet close — the sole caller is InfoPage.dispose() (lib/pages/info/info_page.dart:319). At dispose this wipes episodeList while leaving episodesIsLoading / episodesQueryTimeout set, so the controller is left in a self-contradictory state (flags say "loading"/"failed" with an empty list). It only self-corrects because initState calls resetEpisodesState(); if this controller instance is ever reached without a fresh initState, the gate at info_page.dart:241-243 will permanently skip loading and the sheet shows the skeleton forever.

Align the comment with the actual call site, and prefer a request/subject token over flag juggling to protect against late responses.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

SUGGESTION: clear() + addAll() outside a MobX action publishes an intermediate empty list

These are two independent observable mutations performed outside any action (this store declares no @action, unlike video_controller.dart / download_controller.dart), so each load produces up to four reaction passes and briefly exposes an empty episodeList to the new Observer in episode_list_sheet.dart:222.

Wrap the update in runInAction (or annotate an @action and regenerate codegen) so the list swap and the flag updates are atomic.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

SUGGESTION: These constraints are mostly inert, and the label can still be squeezed on narrow screens

Flexible passes loose constraints, so minWidth: 80 is clamped away by BoxConstraints.enforce whenever free space is smaller (which is exactly the overflow case this is meant to guard), and maxWidth: 160 is never reached because FilledButton.icon takes its ~94dp intrinsic width — the collect button therefore no longer has the stable 120dp width it used to have. With the outer padding of 16/16 (info_page.dart:470) and the vote chart suppressed below 600dp, the right-hand column gets ~136dp at a 320dp screen, leaving ~88dp after the 40dp icon button and 8dp gap — below the button's intrinsic width, so the label is compressed and wraps inside the fixed height: 40 (also reachable at ~1.2x text scale on 360dp).

The RenderFlex overflow is fixed, but consider FittedBox, a maxLines: 1 + ellipsis label, or dropping the fixed height so the squeeze degrades gracefully.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

SUGGESTION: This mounted check cannot prevent post-dispose work

The guard runs before the only await and no state is touched after it, so it protects nothing; what it does do is silently no-op a 重试 tap in an edge case (the sheet is a separate route, so it can outlive the page State), leaving the user with an error view and an unresponsive button.

Drop the guard, or replace it with a post-await staleness check that compares the requested subject id against infoController.bangumiItem.id before the result is applied.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.