Conversation
dawNotPoi
marked this pull request as ready for review
September 21, 2026 06:57
dawNotPoi
marked this pull request as draft
September 21, 2026 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restricts
SymbolCache's dotted-ticker fallback toSecurityType.Basesymbols and adds regression coverage verifying that an Equity key such asLIFE.1cannot satisfy a missing exactLIFElookup.Related Issue
Fixes #9781
Motivation and Context
The dotted-ticker fallback was introduced for custom-data aliases such as
BTC.Bitcoin -> BTC. Applying the same fallback to Equity symbols made resolution depend on registration order: cachingLIFE.1first could cause a later lookup forLIFEto return the wrong security identity. Limiting the fallback to Base/custom-data symbols preserves its intended compatibility behavior without allowing an equity permtick to shadow a distinct ticker.Requires Documentation Change
No. This corrects internal symbol-cache lookup behavior without changing a public API.
How Has This Been Tested?
LIFElookup incorrectly returned the cachedLIFE.1Equity.Tests/QuantConnect.Tests.csprojsuccessfully with the pinned .NET 10 SDK container (zero compile errors).dotnet format whitespace --verify-no-changesandgit diff --check.GIL must always be released). Therefore, this does not claim that the focused NUnit test passed locally; the repository's official environment and complete matrix are left to GitHub CI.Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>.AI-assisted implementation and independent review were used. I reviewed the complete diff and remain responsible for the contribution.