Fixed issue with early test observer registration preventing console output #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Agreed I've run this locally and verified it works – thanks @paweldudek for such a quick turnaround on this 🙇 I'm going to defer to @jeffh on merging. |
This was referenced Mar 25, 2016
| CurrentTestCaseTracker *tracker = [CurrentTestCaseTracker sharedInstance]; | ||
| [[XCTestObservationCenter sharedTestObservationCenter] addTestObserver:tracker]; | ||
| // XCode 7.3 introduced a bug where early registration of a test observer prevented | ||
| // default XCTest test observer from being registered. That caused no longs being printed |
Contributor
There was a problem hiding this comment.
typo longs -> logs; XCode -> Xcode
thanks for the quick PR!
Member
There was a problem hiding this comment.
Nice catch! Let's fix this in another PR/commit.
Member
|
LGTM, thanks for the quick response! Normally I'd defer to @jeffh, but in the interest of unbreaking people's workflow I'll merge this now. If we ever think of a more elegant approach we can fix forward. |
Member
|
@paweldudek mind sending a PR to bump the Nimble submodule in Quick? |
Contributor
Author
|
@modocache looks like @ashfurrow was faster than me 😉 |
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Fixed issue with early test observer registration preventing console output
phatblat
pushed a commit
to phatblat/Nimble
that referenced
this pull request
May 3, 2020
A small typo in documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix #270.
It looks like that early test observer registration (aka as early as you can - in
+load) prevents default XCTest observer from registering in latest XCTest that shipped with Xcode 7.That default observer is responsible for printing output to Xcode console (or Terminal when running
xcodebuildfrom command line). There are several tools that rely on this output, for instancexcpretty.This simple PR adds logic that defers the moment where
CurrentTestCaseTrackerand thus allows default XCTest observer to register.Potential issues: There should not be any issues with
CurrentTestCaseTrackerbeing registered too late as we're moving the registration to next run loop cycle (which is the moment after all classes and categories get their+loadmessage). However I'm entirely certain about and any input on whether this is a viable solution is welcomed.Or perhaps better alternatives, as I'm not a huge fan of using
dispatch_asyncthis way 😉I've tested this against my test suite and it works just fine.