Skip to content

Fixed issue with early test observer registration preventing console output #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
modocache merged 1 commit into from
Mar 25, 2016
Merged

Fixed issue with early test observer registration preventing console output #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Sources/Nimble/objc/CurrentTestCaseTracker.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,14 @@ @implementation CurrentTestCaseTracker (Register)

+ (void)load {
CurrentTestCaseTracker *tracker = [CurrentTestCaseTracker sharedInstance];
[[XCTestObservationCenter sharedTestObservationCenter] addTestObserver:tracker];
// XCode 7.3 introduced a bug where early registration of a test observer prevented
// default XCTest test observer from being registered. That caused no longs being printed
Copy link
Contributor

@morganchen12 morganchen12 Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo longs -> logs; XCode -> Xcode

thanks for the quick PR!

Copy link
Member

@modocache modocache Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Let's fix this in another PR/commit.

Copy link
Contributor

@morganchen12 morganchen12 Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #272 to address this 👍

// onto console, which in result broke several tools that relied on this.
// In order to go around the issue we're deferring registration to allow default
// test observer to register first.
dispatch_async(dispatch_get_main_queue(), ^{
[[XCTestObservationCenter sharedTestObservationCenter] addTestObserver:tracker];
});
}

@end