Skip to content

OMPT Target Offload Support - #411

Merged
dgaliffiAMD merged 26 commits into
amd-stagingfrom
jomadsen/ompt-target-support
Oct 30, 2024
Merged

OMPT Target Offload Support#411
dgaliffiAMD merged 26 commits into
amd-stagingfrom
jomadsen/ompt-target-support

Conversation

@jrmadsen

@jrmadsen jrmadsen commented Oct 24, 2024

Copy link
Copy Markdown
Collaborator

Fixes OMPT support for OpenMP Target Offload applications

  • additionally fixes issue with perfetto

@jrmadsen
Update lib/omnitrace/library/tracing.hpp
9f49ea3 
- generic tracing::get_clock_skew(...) function
@jrmadsen
Update .gitmodules
1deb3b4 
- use github.com/ROCm/timemory instead of github.com/NERSC/timemory
@jrmadsen
Update timemory submodule
57fd356 
- improved OMPT support
@jrmadsen
Update lib/core/config.*
4792f88 
- new tmp_file::open member function (public)
- new tmp_file::touch member function (private)
- handle pid changing due to forking
@jrmadsen
Update lib/core/perfetto.cpp
bd9e7aa 
- fix "unknown field type" error
@jrmadsen
Update lib/omnitrace/library/roctracer.cpp
f745a78 
- use new (generic) tracing::get_clock_skew(...) function
@jrmadsen
Update lib/omnitrace/library/runtime.cpp
96e7e25 
- fix warning regarding get_reserved_vector<bool>
@jrmadsen
Add openmp-target example and test
0eb60fe
@jrmadsen
Update OMPT support
37c0848 
- lib/omnitrace/library/ompt.cpp
- new component::ompt
  - uses category_region
- handle OMPT target offload buffer records
@jrmadsen jrmadsen added bug fix Fixes a bug perfetto Issue affects/involves perfetto features/capabilities timemory Issue affects/involves timemory features/capabilities OMPT OpenMP tools submodule Updates a git submodule new feature Introduces new feature labels Oct 24, 2024
@jrmadsen
jrmadsen requested a review from dgaliffiAMD as a code owner October 24, 2024 22:20
dgaliffiAMD and others added 14 commits October 24, 2024 23:15
@dgaliffiAMD
Skip openmp target example if amdclang is not installed
2d84e51 
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@dgaliffiAMD
Use package manager for CMake install
8bad7db
@dgaliffiAMD
Revert "Use package manager for CMake install"
119bbc4 
This reverts commit 8bad7db.
@dgaliffiAMD
Update cmake
bfa0623
@dgaliffiAMD
Upgrade PIP packages
ab2303c 
Make sure the latest cmake is installed.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@dgaliffiAMD
Update ci workflows to install texinfo and bison
ae70fa9 
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@dgaliffiAMD
Update redhat.yml
9080f6e 
Need to install crb enable before installing texinfo
@dgaliffiAMD
Update redhat.yml
81320b2 
Installing dnf-command(config-manager) is required to enable CRB for rockylinux 9.0
@dgaliffiAMD
Add gettext to ubuntu-focal job.
51b4eb0 
Required to build Dyninst
@dgaliffiAMD
Update OMPT example CMakeLists
2933581 
Add "${OMP_TARGET_COMPILER_DIR}/llvm/lib" to the BUILD_RPATH. This path is common to new and old versions of ROCm
@dgaliffiAMD
Update REPO_URL to Timemory in Packages.cmake
8ff0bc1
@dgaliffiAMD
Format CMake files
20e058c 
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@dgaliffiAMD
Skip the OMP Target example for ROCm < 5.6
17a5584
@jrmadsen
Update timemory submodule
9fe02b5 
- fixes for openmp::get_enum_label
- removed ignoring the first implicit task for non-main threads
dgaliffiAMD added a commit to dgaliffiAMD/rocprofiler-systems that referenced this pull request Oct 31, 2024
@dgaliffiAMD
OMPT Target Offload Support
9783b85 
* Porting from ROCm/omnitrace#411
* Improve OMPT support
* Add OpenMP target example to testing
* Update Timemory submodule to use ROCm/Timemory rather than
  NERSC/Timemory

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@dgaliffiAMD dgaliffiAMD mentioned this pull request Nov 1, 2024
Merged
dgaliffiAMD added a commit to ROCm/rocprofiler-systems that referenced this pull request Nov 5, 2024
@dgaliffiAMD
Fix for proto files not being viewable in Perfetto UI (#16)
21d9ab7 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD added a commit to dgaliffiAMD/rocprofiler-systems that referenced this pull request Nov 6, 2024
@dgaliffiAMD
OMPT Target Offload Support
99db079 
* Porting from ROCm/omnitrace#411
* Improve OMPT support
* Add OpenMP target example to testing
* Update Timemory submodule to use ROCm/Timemory rather than
  NERSC/Timemory

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD added a commit to dgaliffiAMD/rocprofiler-systems that referenced this pull request Nov 6, 2024
@dgaliffiAMD
Fix for proto files not being viewable in Perfetto UI (ROCm#16)
2144a26 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@dgaliffiAMD dgaliffiAMD mentioned this pull request Nov 6, 2024
Merged
dgaliffiAMD added a commit to ROCm/rocprofiler-systems that referenced this pull request Nov 7, 2024
@dgaliffiAMD
OMPT Target Offload Support (#17)
7dce592 
- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Update `actions/upload-artifacts` to v4
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples
- Updated Ubuntu 20.04 workflows
dgaliffiAMD added a commit to ROCm/rocprofiler-systems that referenced this pull request Nov 8, 2024
@dgaliffiAMD
OMPT Target Offload Support (#17)
ab88377 
- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Update `actions/upload-artifacts` to v4
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples
- Updated Ubuntu 20.04 workflows
@dgaliffiAMD dgaliffiAMD mentioned this pull request Nov 9, 2024
Merged
dgaliffiAMD added a commit to ROCm/rocprofiler-systems that referenced this pull request Nov 18, 2024
@dgaliffiAMD
Fix for proto files not being viewable in Perfetto UI (#16)
46ca5ca 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD added a commit to ROCm/rocprofiler-systems that referenced this pull request Nov 18, 2024
@dgaliffiAMD
OMPT Target Offload Support (#17)
9da7365 
- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Update `actions/upload-artifacts` to v4
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples
- Updated Ubuntu 20.04 workflows
dgaliffiAMD added a commit to ROCm/rocprofiler-systems that referenced this pull request Nov 20, 2024
@dgaliffiAMD
OMPT Target Offload Support (#17)
502fdda 
- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Update `actions/upload-artifacts` to v4
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples
- Updated Ubuntu 20.04 workflows
dgaliffiAMD added a commit to dgaliffiAMD/rocprofiler-systems that referenced this pull request Nov 20, 2024
@dgaliffiAMD
Fix for proto files not being viewable in Perfetto UI (ROCm#16)
ef69642 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD added a commit to ROCm/rocprofiler-systems that referenced this pull request Nov 20, 2024
@dgaliffiAMD
OMPT Target Offload Support
4805251 
- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD added a commit to dgaliffiAMD/rocprofiler-systems that referenced this pull request Nov 20, 2024
@dgaliffiAMD
Fix for proto files not being viewable in Perfetto UI (ROCm#16)
e88eb93 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
ashuverm pushed a commit to ROCm/rocprofiler-systems that referenced this pull request Nov 22, 2024
@dgaliffiAMD @ashuverm
OMPT Target Offload Support
489214c 
- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
ashuverm pushed a commit to ROCm/rocprofiler-systems that referenced this pull request Nov 22, 2024
@dgaliffiAMD @ashuverm
Fix for proto files not being viewable in Perfetto UI (#16)
1fd7a1c 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
ashuverm pushed a commit to ROCm/rocprofiler-systems that referenced this pull request Nov 27, 2024
@dgaliffiAMD @ashuverm
OMPT Target Offload Support
71d343e 
- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
ashuverm pushed a commit to ROCm/rocprofiler-systems that referenced this pull request Nov 27, 2024
@dgaliffiAMD @ashuverm
Fix for proto files not being viewable in Perfetto UI (#16)
03c24de 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@jrmadsen jrmadsen mentioned this pull request Dec 5, 2024
Closed
vamovsik pushed a commit to ROCm/rocprofiler-systems that referenced this pull request Dec 5, 2024
@dgaliffiAMD
Fix for proto files not being viewable in Perfetto UI (#16) (#19)
6b848fb 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
vamovsik pushed a commit to ROCm/rocprofiler-systems that referenced this pull request Dec 9, 2024
@dgaliffiAMD
[6.3] OMPT Target Offload Support (#26)
04a84dd 
* OMPT Target Offload Support

- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Resolve compilation warning with gcc 13

* Add test for ompt-target

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
ammallya pushed a commit to ROCm/rocm-systems that referenced this pull request Aug 6, 2025
@dgaliffiAMD
Fix for proto files not being viewable in Perfetto UI (#16)
7eaaa83 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 21d9ab7]
ammallya pushed a commit to ROCm/rocm-systems that referenced this pull request Aug 6, 2025
@dgaliffiAMD
OMPT Target Offload Support (#17)
6a6fd7f 
- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Update `actions/upload-artifacts` to v4
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples
- Updated Ubuntu 20.04 workflows

[ROCm/rocprofiler-systems commit: 7dce592]
ammallya pushed a commit to ROCm/rocm-systems that referenced this pull request Aug 6, 2025
@dgaliffiAMD
Fix for proto files not being viewable in Perfetto UI (#16)
affeda8 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 46ca5ca]
ammallya pushed a commit to ROCm/rocm-systems that referenced this pull request Aug 6, 2025
@dgaliffiAMD
OMPT Target Offload Support (#17)
d8c98d2 
- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Update `actions/upload-artifacts` to v4
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples
- Updated Ubuntu 20.04 workflows

[ROCm/rocprofiler-systems commit: 9da7365]
ammallya pushed a commit to ROCm/rocprofiler-systems that referenced this pull request Oct 28, 2025
@dgaliffiAMD
Fix for proto files not being viewable in Perfetto UI (#16)
656a1fd 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 46ca5ca]
ammallya pushed a commit to ROCm/rocprofiler-systems that referenced this pull request Oct 28, 2025
@dgaliffiAMD
OMPT Target Offload Support (#17)
fcfce05 
- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Update `actions/upload-artifacts` to v4
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples
- Updated Ubuntu 20.04 workflows

[ROCm/rocprofiler-systems commit: 9da7365]
ammallya pushed a commit to ROCm/rocprofiler-systems that referenced this pull request Oct 28, 2025
@dgaliffiAMD
Fix for proto files not being viewable in Perfetto UI (#16)
8e4f720 
- Fix for proto files not being viewable in Perfetto UI
  - Ported from ROCm/omnitrace#411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 21d9ab7]
ammallya pushed a commit to ROCm/rocprofiler-systems that referenced this pull request Oct 28, 2025
@dgaliffiAMD
OMPT Target Offload Support (#17)
12ec1ac 
- Porting from ROCm/omnitrace#411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Update `actions/upload-artifacts` to v4
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples
- Updated Ubuntu 20.04 workflows

[ROCm/rocprofiler-systems commit: 7dce592]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgaliffiAMD dgaliffiAMD dgaliffiAMD approved these changes

Assignees

No one assigned

Labels

bug fix Fixes a bug new feature Introduces new feature OMPT OpenMP tools perfetto Issue affects/involves perfetto features/capabilities submodule Updates a git submodule timemory Issue affects/involves timemory features/capabilities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrmadsen @dgaliffiAMD