Repository navigation
Move properties transmitted in identify to variable on DiscordWebSocket - #10513
Open
pythonmcpi wants to merge 1 commit into
Open
pythonmcpi wants to merge 1 commit into
pythonmcpi wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the client properties sent in websocket IDENTIFY to a variable on
DiscordWebSocket. This makes overriding them easier, and more specifically discourages monkeypatching out the whole identify method, which can break things when the library updates.Originally suggested by Soheab in this bikeshedding thread.
This is intentionally not documented as bots being able to change these properties is not something Discord documents or officially supports.
Snippet for applying mobile status after this change:
Snippet for applying VR status after this change:
Checklist