[BugFix] fix json length check #66628
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Murphy <mofei@starrocks.com>
Contributor
🧪 CI InsightsHere's what we observed from your CI run for b81f3cd. 🟢 All jobs passed!But CI Insights is watching 👀 |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an off-by-one error in JSON to VARCHAR schema change validation. The issue was that when converting a JSON column to VARCHAR, the code incorrectly rejected VARCHAR with exactly the minimum required length of 1024 bytes.
Key Change:
- Fixed the comparison operator in
Column.checkSchemaChangeAllowed()from<=to<to allow VARCHAR(1024) when converting from JSON type, which has a minimum type size of 1024 bytes.
|
Contributor
|
@cursor review |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
HangyuanLiu
approved these changes
Dec 15, 2025
Seaven
approved these changes
Dec 15, 2025
|
@Mergifyio backport branch-3.5 |
|
@Mergifyio backport branch-4.0 |
Contributor
✅ Backports have been createdDetails
|
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
(cherry picked from commit ed8b59b)
23 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
(cherry picked from commit ed8b59b)
23 tasks
murphyatwork
added a commit
that referenced
this pull request
Dec 15, 2025
(cherry picked from commit ed8b59b)
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 15, 2025
murphyatwork
added a commit
that referenced
this pull request
Dec 15, 2025
(cherry picked from commit ed8b59b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Minimal length is 1024, which should be allowed.
Fixes #https://github.com/StarRocks/StarRocksTest/issues/10673
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Permits schema change from JSON to CHAR/VARCHAR when target length equals the JSON minimum (e.g., 1024).
Column.checkSchemaChangeAllowed, relax JSON length check: change<=to<so converting JSON toCHAR/VARCHARis allowed when targetstrLenequalsPrimitiveType.JSON.getTypeSize().Written by Cursor Bugbot for commit b81f3cd. This will update automatically on new commits. Configure here.