[Refactor:TAGrading] Move student info panel to vue - #11889
Merged
Merged
Conversation
…bmitter models; migrate StudentInformationPanel and VersionChoice to Vue components
…odels; adjust VersionChoice component reference in CurrentVersionBox.twig
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11889 +/- ##
=============================================
- Coverage 88.88% 21.73% -67.16%
- Complexity 0 9338 +9338
=============================================
Files 9 267 +258
Lines 531 35862 +35331
Branches 0 474 +474
=============================================
+ Hits 472 7793 +7321
- Misses 59 27599 +27540
- Partials 0 470 +470
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…ps and event handling
…ry in create_course.sh
williamschen23
requested changes
Jul 29, 2025
williamschen23
left a comment
Contributor
There was a problem hiding this comment.
Left some comments, overall remove most/all console.logs and then remove the inline css. In addition, if this is switching a student version, some alert should display showing if we really want to cahnge the version
…nd remove onChange handling
williamschen23
requested changes
Jul 30, 2025
williamschen23
left a comment
Contributor
There was a problem hiding this comment.
add back the original alert and move inline css to a vue css field and this is good!
…r improved readability and maintainability
williamschen23
approved these changes
Jul 31, 2025
Member
|
@lavalleeale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
This moves the second tagrading panel to vue.
What is the New Behavior?
Student info is rendered with vue and the twig + separate scripts are removed.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
The student info panel and version choice box already are thoroughly tested.
Other information