Conversation
There is currently the potential for unexpected behavior when resolving entries from parent containers where a parent registration can access and store objects resolved from a child container (see unit tests). This introduces a configuration to modify this access.
bradfol
force-pushed
the
bradfol/container-capture
branch
from
May 29, 2024 18:06
8efecbe to
da9ee0f
Compare
bradfol
marked this pull request as ready for review
May 29, 2024 18:07
bradfol
commented
May 29, 2024
| behaviors: [Behavior] = [], | ||
| registeringClosure: (Container) -> Void = { _ in } | ||
| registeringClosure: (Container) -> Void = { _ in }, | ||
| resolverHierarchyAccess: ResolverHierarchyAccess = .receiver |
Contributor
Author
There was a problem hiding this comment.
I left the default here as the current behavior, but it would be nice to discuss changing the default in a future version.
bradfol
commented
May 30, 2024
Comment on lines
+120
to
+122
| XCTAssert(child.resolve(Animal.self, name: "Spot") is Cat) | ||
| // The instance provided by the child leaks into the parent | ||
| XCTAssert(parent.resolve(Animal.self, name: "Spot") is Cat) |
Contributor
Author
There was a problem hiding this comment.
Also want to call attention to this test case as this behavior is the most unexpected/problematic of the way things currently work
skorulis-ap
approved these changes
Jun 3, 2024
Contributor
|
Will look at this soon to see if I can merge this as part of a new release cut. |
bradfol
added a commit
to cashapp/knit
that referenced
this pull request
Jan 29, 2025
There is a potential bug with resolution when using parent-child containers and shadowed registrations. This fix ensures that when performing resolution that a parent container can never have access to registrations in a child container. Previously, the container that received the `resolve()` call was captured and used for later factory invocations, and if that receiver was a child that also had a shadowed registration of the parent then the bug could emerge. This implements the same change as Swinject/Swinject#567 but does not retain an option to use the old behavior. Instead, we are considering the old Swinject behavior to be a bug, and are directly fixing for Knit.
bradfol
marked this pull request as draft
January 31, 2025 23:47
Contributor
Author
|
When testing this change @skorulis-ap discovered that it does not work properly with the way that synchronized containers are set up. This is due to the part where the synchronized container contains no service entries, all entries are on the unsynchronized container, which means the modified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently the potential for unexpected behavior when resolving entries from parent containers where a parent registration can access and store objects resolved from a child container (see unit tests). This introduces a configuration to modify this access.