Skip to content

FEATURE: [2.2] [AdminBundle] #15888 Introduce sylius:admin-user:delete CLI Command #15889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rafikooo merged 3 commits into from
Dec 11, 2025
Merged

FEATURE: [2.2] [AdminBundle] #15888 Introduce sylius:admin-user:delete CLI Command #15889

Rafikooo merged 3 commits into from
Dec 11, 2025

Conversation

@crydotsnake
Copy link
Member

@crydotsnake crydotsnake commented Feb 25, 2024 •
edited
Loading

Q A
Branch? 2.2
Bug fix? no.
New feature? yes.
Deprecations? no.
Related tickets #15888
License MIT

This change introduced the new CLI Command:

bin/console sylius:admin-user:delete [email]

This deletes an admin backend user by the given email.

Its also possible to run the command non-interactive:

bin/console sylius:admin-user:delete [email] --no-interaction

@crydotsnake crydotsnake requested a review from a team as a code owner February 25, 2024 14:19
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Feb 25, 2024
@github-actions
Copy link

github-actions bot commented Feb 25, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@crydotsnake
Copy link
Member Author

crydotsnake commented Feb 25, 2024

PHPStan still fails.. will check!

@crydotsnake crydotsnake force-pushed the feature/15888/admin-user-delete-command branch from 98ca674 to 99b32dc Compare February 25, 2024 14:49
@crydotsnake crydotsnake changed the title FEATURE: #15888 Introduce sylius:admin-user:delete CLI Command FEATURE: #15888 [AdminBundle] Introduce sylius:admin-user:delete CLI Command Feb 27, 2024
@crydotsnake
Copy link
Member Author

crydotsnake commented Mar 4, 2024 •
edited
Loading

I adjusted the behavior again. Its more conviniend do delete the user by the given username instead of the e-mail address.

Will squash my commits to one after i implemented any possible feedback.

@crydotsnake crydotsnake mentioned this pull request Mar 4, 2024
Merged
Rafikooo
Rafikooo reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Rafikooo Rafikooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @crydotsnake. Thank you for your recent contributions. As with the PR for the admin users listing, it would be beneficial to include tests 🕺

NoResponseMate
NoResponseMate reviewed Mar 8, 2024
View reviewed changes
@crydotsnake crydotsnake changed the base branch from 1.13 to 2.2 September 26, 2025 09:40
@crydotsnake crydotsnake requested a review from a team as a code owner September 26, 2025 09:40
@Rafikooo
Copy link
Contributor

Rafikooo commented Sep 26, 2025

Rebase needed 🕺

@crydotsnake
Copy link
Member Author

crydotsnake commented Sep 26, 2025

Rebase needed 🕺

Already noticed. Will take care :)

@crydotsnake crydotsnake force-pushed the feature/15888/admin-user-delete-command branch from 3a9779d to a651c81 Compare September 27, 2025 04:02
@coderabbitai
Copy link

coderabbitai bot commented Sep 27, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@crydotsnake
Copy link
Member Author

crydotsnake commented Sep 27, 2025

@Rafikooo Rebase finished :) !

@crydotsnake crydotsnake force-pushed the feature/15888/admin-user-delete-command branch from de21f29 to a2aaaf8 Compare September 27, 2025 04:55
@crydotsnake crydotsnake force-pushed the feature/15888/admin-user-delete-command branch from a2aaaf8 to 5e0f38c Compare October 18, 2025 10:54
@crydotsnake
Copy link
Member Author

crydotsnake commented Oct 19, 2025

Hello @crydotsnake. Thank you for your recent contributions. As with the PR for the admin users listing, it would be beneficial to include tests 🕺

Hello Rafał!

I added the unit test 🙂!

@crydotsnake crydotsnake added the Feature New feature proposals. label Oct 23, 2025
@crydotsnake crydotsnake changed the title FEATURE: #15888 [AdminBundle] Introduce sylius:admin-user:delete CLI Command FEATURE: [2.2] [AdminBundle] #15888 Introduce sylius:admin-user:delete CLI Command Oct 23, 2025
@crydotsnake crydotsnake self-assigned this Nov 5, 2025
@crydotsnake crydotsnake force-pushed the feature/15888/admin-user-delete-command branch from 98f14c2 to ceb92f2 Compare November 24, 2025 19:40
@crydotsnake
Copy link
Member Author

crydotsnake commented Nov 24, 2025

FYI: I rebased the branch 🙂

@crydotsnake crydotsnake force-pushed the feature/15888/admin-user-delete-command branch from ceb92f2 to 7b9d771 Compare December 5, 2025 07:35
@crydotsnake
FEATURE: Sylius#15888 Introduce sylius:admin-user:delete CLI Command
1193038 
TASK: delete user by given username instead of email

TASK: add confirmation question before deleting the administrator account

TASK: delete duplicate service entry for DeleteAdminUserCommand

TASK: allow command to also run non-interactive

TASK: apply PHP CS fixes

TASK: inject and use AdminUserInterface instead of UserInterface

TASK: allow deleting the user by the email only instead of the username

TASK: add unit test for DeleteAdminUserCommand

TASK: [AdminBundle] add env name="COLUMNS" too phpunit.xml.dist
@crydotsnake crydotsnake force-pushed the feature/15888/admin-user-delete-command branch from 7b9d771 to 1193038 Compare December 10, 2025 09:55
@Rafikooo Rafikooo linked an issue Dec 10, 2025 that may be closed by this pull request
[CLI FEATURE] Command for deleting an admin user by the given email #15888
Closed
GSadee
GSadee reviewed Dec 11, 2025
View reviewed changes
@Rafikooo Rafikooo force-pushed the feature/15888/admin-user-delete-command branch from 7889a59 to 9bf76a0 Compare December 11, 2025 19:27
@Rafikooo Rafikooo merged commit a016167 into Sylius:2.2 Dec 11, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GSadee GSadee GSadee left review comments

@Rafikooo Rafikooo Rafikooo approved these changes

@NoResponseMate NoResponseMate Awaiting requested review from NoResponseMate

Assignees

@crydotsnake crydotsnake

Labels

Admin AdminBundle related issues and PRs. Feature New feature proposals.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CLI FEATURE] Command for deleting an admin user by the given email

4 participants

@crydotsnake @Rafikooo @GSadee @NoResponseMate