src/Sylius/Bundle/AdminBundle/Console/Command/ListAdminUsersCommand.php (1)

71-93: Render one table for all users and handle the empty case.

Currently a separate table is printed per user and there’s duplication with listSingleAdminUser. Prefer one table; warn if none. (Also addresses an earlier comment about reuse.)

     private function listAllAdminUsers(): void
     {
-        $adminUsers = $this->userRepositoryInterface->findAll();
-        /** @var AdminUser $adminUser */
-        foreach ($adminUsers as $adminUser) {
-            $this->io->table(
-                [
-                    'ID', 'E-Mail', 'Username', 'First name', 'Last name', 'Locale code', 'Enabled',
-                ],
-                [
-                    [
-                        $adminUser->getId(),
-                        $adminUser->getEmail(),
-                        $adminUser->getUsername(),
-                        $adminUser->getFirstname() ?? 'No Firstname Set',
-                        $adminUser->getLastName() ?? 'No Lastname Set',
-                        $adminUser->getLocaleCode(),
-                        $adminUser->isEnabled() ? 'Enabled' : 'Disabled',
-                    ],
-                ],
-            );
-        }
+        $adminUsers = $this->adminUserRepository->findAll();
+        if ($adminUsers === []){
+            $this->io->warning('No admin users found.');
+            return;
+        }
+
+        $rows = array_map(
+            static function (AdminUserInterface $adminUser): array {
+                return [
+                    $adminUser->getId(),
+                    $adminUser->getEmail(),
+                    $adminUser->getUsername(),
+                    $adminUser->getFirstName() ?? 'No first name set',
+                    $adminUser->getLastName() ?? 'No last name set',
+                    $adminUser->getLocaleCode(),
+                    $adminUser->isEnabled() ? 'Enabled' : 'Disabled',
+                ];
+            },
+            $adminUsers,
+        );
+
+        $this->io->table(
+            ['ID', 'Email', 'Username', 'First name', 'Last name', 'Locale code', 'Enabled'],
+            $rows,
+        );
     }

src/Sylius/Bundle/AdminBundle/Console/Command/ListAdminUsersCommand.php (6)

32-32: Restrict visibility of $io.

Make it private; the class is final and nothing extends it.

-    protected SymfonyStyle $io;
+    private SymfonyStyle $io;

---

46-50: Drop redundant PHPDoc on execute().

Types are already declared; remove the boilerplate per coding guidelines.

-    /**
-     * @param InputInterface $input
-     * @param OutputInterface $output
-     * @return int
-     */

---

78-78: Consistent header label.

Prefer “Email” over “E-Mail”.

-                    'ID', 'E-Mail', 'Username', 'First name', 'Last name', 'Locale code', 'Enabled',
+                    'ID', 'Email', 'Username', 'First name', 'Last name', 'Locale code', 'Enabled',

-                'ID', 'E-Mail', 'Username', 'First name', 'Last name', 'Locale code', 'Enabled',
+                'ID', 'Email', 'Username', 'First name', 'Last name', 'Locale code', 'Enabled',

Also applies to: 100-100

---

74-74: Prefer interface types in annotations or remove them.

Docblocks reference the concrete AdminUser; either switch to AdminUserInterface or drop the annotations (they’re not needed).

-        /** @var AdminUser $adminUser */
+        /** @var AdminUserInterface $adminUser */

-        /** @var AdminUser $adminUser */
+        /** @var AdminUserInterface $adminUser */

Also applies to: 97-97

---

95-114: Optional DRY: extract a row builder and reuse headers.

Reduce duplication between listAllAdminUsers and listSingleAdminUser by extracting a toRow(AdminUserInterface) and a TABLE_HEADERS constant.

Example:

private const TABLE_HEADERS = ['ID', 'Email', 'Username', 'First name', 'Last name', 'Locale code', 'Enabled'];

private function toRow(AdminUserInterface $u): array
{
    return [
        $u->getId(),
        $u->getEmail(),
        $u->getUsername(),
        $u->getFirstName() ?? 'No first name set',
        $u->getLastName() ?? 'No last name set',
        $u->getLocaleCode(),
        $u->isEnabled() ? 'Enabled' : 'Disabled',
    ];
}

private function listSingleAdminUser(AdminUserInterface $adminUser): void
{
    $this->io->table(self::TABLE_HEADERS, [$this->toRow($adminUser)]);
}

---

51-69: Please add tests for the command.

Cover happy path (all users), filter by existing username, and “not found” failure (exit code 1). Use CommandTester.

Sample:

public function test_it_lists_all_admin_users(): void
{
    // arrange fixtures (2 admin users)
    // act
    $tester = new CommandTester(self::getContainer()->get(ListAdminUsersCommand::class));
    $exit = $tester->execute([]);
    // assert
    self::assertSame(Command::SUCCESS, $exit);
    $display = $tester->getDisplay();
    self::assertStringContainsString('Admin users', $display);
    self::assertStringContainsString('Enabled', $display);
}

public function test_it_lists_one_user_when_username_is_provided(): void { /* ... */ }

public function test_it_fails_when_username_not_found(): void { /* ... */ }

I can scaffold these in a dedicated test class if helpful.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/Sylius/Bundle/AdminBundle/Resources/config/services.xml (1)

56-59: Align service ID/visibility with existing console commands

Other commands here use a named service ID and are marked public. For consistency, consider switching to a named ID, add the class attribute, and set public="true". Indentation can also follow the file’s convention.

-        <service id="Sylius\Bundle\AdminBundle\Console\Command\ListAdminUsersCommand">
-            <argument type="service" id="sylius.repository.admin_user" />
-            <tag name="console.command" />
-        </service>
+        <service id="sylius_admin.console.command.list_admin_users"
+                 class="Sylius\Bundle\AdminBundle\Console\Command\ListAdminUsersCommand"
+                 public="true">
+            <argument type="service" id="sylius.repository.admin_user" />
+            <tag name="console.command" />
+        </service>

Note: If #[AsCommand] is present, the explicit tag is optional; keeping it is fine for parity with neighbors.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro