fix(shell): use POSIX file tests in bash --use-on-cd hook - #1593
Open
vulragrag-star wants to merge 1 commit into
Open
vulragrag-star wants to merge 1 commit into
vulragrag-star wants to merge 1 commit into
Conversation
Bash's generated cd hook used `[[ -f ... ]]`, which fails under dash/sh (`[[: not found`) so --use-on-cd silently never runs `fnm use`. Emit POSIX `[ -f ]` tests instead (valid in bash and sh). Fixes Schniz#1591
JustinM1911
approved these changes
Sep 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bash
--use-on-cdemittedif [[ -f .node-version || ... ]]; then, which is not POSIX. Under dash/sh that errors as[[: not foundand the hook never runsfnm use.Switch the generated condition to POSIX
[ -f ... ] || [ -f ... ]tests (valid in bash and sh).Fixes #1591
Test plan
cargo test use_on_cd_emits_posix_file_testse2e/use-on-cd.test.tsbash matrix still passes