Repository navigation
Refactor browser fixes and optimize scroll reset behavior for perform… - #6105
Open
Avinash99b wants to merge 1 commit into
Open
Avinash99b wants to merge 1 commit into
Avinash99b wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Summary
This branch contains the changes from commit
4c4d9258. It includes two targeted performance and correctness fixes:Changes
public/scripts/browser-fixes.jsdocument.documentElement.style.position.isMobileimport.public/scripts/keyboard.jsWeakSettoapplyScrollResetBehavior.focusoutlisteners from being attached when the function is called repeatedly during DOM/class updates.WeakSetso removed containers can still be garbage-collected.Why
Testing
scrollTop/scrollLeftcorrectly.isMobilereferences inbrowser-fixes.js.Notes
The original commit was force-removed from
release(origin/releaseis now at8172dcd0) and is maintained onperf/mobile-chat-input-optim. No otherreleasechanges are included in this PR.