Repository navigation
Conversation
This was referenced Oct 10, 2026
axAilotl
marked this pull request as ready for review
October 10, 2026 18:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHARX imports now preserve creator-provided filenames for gallery images, audio, video, and JSON, and store them under the character's media folders. Expression sprites retain their existing normalized labels. These paths work with the existing file routes and user-installed regex scripts.
Validation against real archives exposed two data/path problems: colliding non-sprite filenames could overwrite assets, and literal percent signs were decoded twice by the file route. Imports now choose stable collision suffixes and serve encoded filenames correctly. APNG and AVIF support is also preserved.
Validated on upstream
stagingatad29cbda6:npm run lintand tests lint pass; tests lint reports two existing warnings.Reproduce against a disposable server with
ST_BASE_URL,ST_CHARX_IMPORT_E2E=1, and optionallyST_CHARX_FIXTURE_DIR: runnpx playwright test charx-import.e2e.js --workers=1fromtests.