Repository navigation
Configurable display timezone, dependency updates, v1.0.4 - #5
Merged
Merged
Conversation
- @tak-ps/etl 10.9.0 -> 10.13.0 - eslint 10.8.0 -> 10.9.0 - typescript-eslint 8.65.0 -> 8.67.0 typescript stays pinned at 6.0.3 (latest 6.x): typescript-eslint's peer dependency still caps at <6.1.0, so TypeScript 7.x is not yet installable alongside it without breaking lint/type-checking. Verified: npm run build, npm run lint, tsc --noEmit, npm audit (0 vulnerabilities) all pass.
- Add TIMEZONE env var (IANA name, default Pacific/Auckland) controlling the local time shown alongside UTC in remarks/metadata - Replace hardcoded NZ-only Intl.DateTimeFormat instances with a per-timezone formatter cache (getFormatters), built once per distinct timezone string used in a run - Fall back to the default timezone (with a logged warning) if an invalid IANA timezone string is configured, instead of throwing - Generalize remarks/labels from 'NZ'/'NZT' to 'Local' since the configured zone is no longer necessarily NZ (actual abbreviation like NZST/AEST still comes from Intl's timeZoneName) - Fixes forecast table dates using the UTC calendar day instead of the configured local calendar day (toLocalDate, formerly toNzDate)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the local-time display timezone configurable instead of hardcoded to
NZ, fixes a related date-boundary bug, and does routine dependency
maintenance.
Configurable timezone
TIMEZONEenvironment variable (IANA name, defaultPacific/Auckland)controlling the local time shown alongside UTC in remarks/metadata
Intl.DateTimeFormatinstances with aper-timezone formatter cache, built once per distinct timezone string used
in a run
IANA timezone string is configured, instead of throwing
NZ/NZTtoLocal, since the configuredzone is no longer necessarily NZ — the actual abbreviation (e.g.
NZST,AEST) still comes fromIntl'stimeZoneNameconfigured local calendar day (
toLocalDate, formerlytoNzDate) — datesnear a UTC day boundary could previously show the wrong local day
Dependency updates
@tak-ps/etl10.9.0 → 10.13.0 (changelog reviewed: additive only —permissions validation, new capabilities format, tooling)
eslint10.8.0 → 10.9.0typescript-eslint8.65.0 → 8.67.0typescriptstays pinned at 6.0.3 (latest 6.x):typescript-eslint's peerrange still caps at
<6.1.0, so TypeScript 7.x isn't yet installablealongside it without breaking lint/type-checking
1.0.4, CHANGELOG updatedTesting
npx tsc --noEmit— passesnpm run lint— passesnpm run build— passesnpm audit— 0 vulnerabilitiesalternate zone (
Australia/Sydney), and an invalid zone string (confirmsfallback + warning) via a standalone script
Not verified: end-to-end run against the live Google Flood Forecasting API
(requires
API_KEY/ETL_*credentials).Blocked / follow-ups
typescriptto 7.x oncetypescript-eslintadds support.