Repository navigation
Add preliminary events filter, bump to v1.0.5 - #6
Merged
Merged
Conversation
Checked all dependencies against latest available versions; already up to date. typescript remains pinned at 6.0.3 pending typescript-eslint TypeScript 7 support (peer range still caps at <6.1.0). Verified: npm run build, npm run lint, tsc --noEmit, npm audit (0 vulnerabilities) all pass.
- Add INCLUDE_PRELIMINARY_EVENTS env var (default true) to optionally suppress gauges/basin polygons whose elevated severity is still preliminary (not yet confirmed across MIN_CONFIRMING_ISSUANCES forecast issuances), letting operators trade earlier notice for fewer false positives - Add preliminary boolean to OutputSchema and gauge/basin metadata, alongside the existing confirmed field - Expand INCLUDE_SIGNIFICANT_EVENTS description to explain what a significant event is (area-wide event clustered from gauge discharge predictions exceeding danger thresholds, weighted by affected population/area) and what the flag controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a way to suppress unconfirmed ("preliminary") severity alerts entirely,
clarifies the Significant Events flag, and bumps the version.
Preliminary events filter
INCLUDE_PRELIMINARY_EVENTSenvironment variable (defaulttrue) tooptionally exclude gauges and basin polygons whose elevated severity is
still preliminary — i.e. not yet confirmed across
MIN_CONFIRMING_ISSUANCESdaily forecast issuances
to
false, on top of the existing "(preliminary)" labelingpreliminaryboolean toOutputSchemaand to gauge/basinmetadata,alongside the existing
confirmedfieldDocumentation
INCLUDE_SIGNIFICANT_EVENTSdescription to explain what asignificant event actually is (an area-wide event clustered from gauge
discharge predictions exceeding danger thresholds, weighted by affected
population/area) and what the flag controls (polygon rendering +
[event]gauge cross-referencing)
Version bump
package.jsonversion bumped to1.0.5date, no changes needed
typescriptremains pinned at6.0.3:typescript-eslint's peer rangestill caps at
<6.1.0, so 7.x isn't installable alongside it yetTesting
npx tsc --noEmit— passesnpm run lint— passesnpm run build— passesnpm audit— 0 vulnerabilitiesNot verified: end-to-end run against the live Google Flood Forecasting API
(requires
API_KEY/ETL_*credentials), so the new filter's behavior onreal preliminary/confirmed gauge data hasn't been observed directly.
Blocked / follow-ups
typescriptto 7.x oncetypescript-eslintadds support.