Repository navigation
Expiring flood polygons: stale, hidden marker, icon points - #12
Merged
Merged
Conversation
CloudTAK (node-cot >= 14.58.0) turns the typed flood polygons into markers with a shape/polyline, so ATAK removes them when the marker goes stale. Set a real stale (they had none, so the 20 s default applied), hide the marker (marker-opacity 0) so ATAK does not draw an unknown-type '?', and add a -center icon point for flash flood and significant event polygons so they stay tappable. Bump to 1.1.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloudTAK (
@tak-ps/node-cot>= 14.58.0, dfpc-coe/node-CoT#146) now converts a Polygon with a markertype(a-f-X-i-m-f) into a marker CoT with a<shape><polyline>. ATAK removes the polygon together with the marker atstale; au-d-fdrawing never expires. That already applies to this ETL. This PR handles the side effects, using what we validated on the avalanche ETL (TAK-NZ/etl-avalanche#21):stale, so node-cot's 20 s default applied and they would now vanish almost immediately. Inundation and basin polygons use the gauge forecast end, flash flood polygons use issue time + forecast period, significant events use the minimum end time. A missing or past end falls back to 24 h from the run.marker-color+marker-opacity: 0(<color argb>alpha 0) so ATAK does not draw an unknown-type "?". The polygon has noicon: a validusericonmakes ATAK move the marker to another map group, which deletes the polygon it owns.<id>-centerpoint (flood icon in the polygon colour, same remarks/metadata) so they stay tappable. Inundation and basin polygons rely on their gauge point.CoTParser.from_geojson. Adds@tak-ps/node-cotas a devDependency.npm audit: 0 vulnerabilities. Version 1.1.2.Notes
stale.@tak-ps/node-cot>= 14.58.0.Testing
npm test(11 pass),npm run lint,npm run build,npm audit(0).