Support AWS credentials in tiledb config - #1036
Merged
Merged
Conversation
jakebolewski
approved these changes
Oct 27, 2018
tdenniston
suggested changes
Oct 29, 2018
tdenniston
left a comment
Contributor
There was a problem hiding this comment.
We need to add these parameters to the blacklist (
) so that they are not serialized with the rest of the config params. You'll need to update the config test as well.
Shelnutt2
force-pushed
the
ss/1030-add-aws-key-configs
branch
2 times, most recently
from
October 29, 2018 15:04
0ccbf69 to
8bd2582
Compare
tdenniston
approved these changes
Oct 29, 2018
Shelnutt2
force-pushed
the
ss/1030-add-aws-key-configs
branch
2 times, most recently
from
October 29, 2018 18:49
ba549a6 to
1b2ac92
Compare
Shelnutt2
force-pushed
the
ss/1030-add-aws-key-configs
branch
from
October 30, 2018 00:55
1b2ac92 to
17150be
Compare
This was referenced Oct 30, 2018
ihnorton
pushed a commit
that referenced
this pull request
Feb 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support AWS credentials in tiledb config #1033