Fix FP slice point-query with small (eps) gap coordinates - #1384
Merged
Merged
Conversation
ihnorton
force-pushed
the
ihn/small_fp_pointquery
branch
from
September 25, 2019 20:04
f976834 to
947d9c2
Compare
Fixes problem with queries for floating point slices on array with small gap between coordinates. The overlap ratio goes to 0 and we do not retrieve any points. Found while writing tests for TileDB-Py domain_index support. Co-authored-by: stavros@tiledb.io
ihnorton
force-pushed
the
ihn/small_fp_pointquery
branch
from
September 25, 2019 20:48
947d9c2 to
4034aa3
Compare
tdenniston
pushed a commit
that referenced
this pull request
Sep 30, 2019
* Add test for point query with small gap float coordinates * Fix overlap ratio bug w/ small gap floating point coordinates Fixes problem with queries for floating point slices on array with small gap between coordinates. The overlap ratio goes to 0 and we do not retrieve any points. Found while writing tests for TileDB-Py domain_index support. Co-authored-by: stavros@tiledb.io PR #1384 (cherry picked from commit 485a10e)
tdenniston
pushed a commit
that referenced
this pull request
Sep 30, 2019
* Add test for point query with small gap float coordinates * Fix overlap ratio bug w/ small gap floating point coordinates Fixes problem with queries for floating point slices on array with small gap between coordinates. The overlap ratio goes to 0 and we do not retrieve any points. Found while writing tests for TileDB-Py domain_index support. Co-authored-by: stavros@tiledb.io PR #1384 (cherry picked from commit 485a10e)
tdenniston
pushed a commit
that referenced
this pull request
Oct 1, 2019
* Add test for point query with small gap float coordinates * Fix overlap ratio bug w/ small gap floating point coordinates Fixes problem with queries for floating point slices on array with small gap between coordinates. The overlap ratio goes to 0 and we do not retrieve any points. Found while writing tests for TileDB-Py domain_index support. Co-authored-by: stavros@tiledb.io PR #1384 (cherry picked from commit 485a10e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.