Disable TBB by default - #1762
Merged
Merged
Conversation
joe-maley
force-pushed
the
jpm/disable-tbb
branch
from
August 10, 2020 20:18
1453594 to
efcc14b
Compare
Shelnutt2
suggested changes
Aug 10, 2020
Shelnutt2
left a comment
Contributor
There was a problem hiding this comment.
Please update the history file
joe-maley
force-pushed
the
jpm/disable-tbb
branch
2 times, most recently
from
August 10, 2020 22:56
23f3210 to
dd8e8b9
Compare
stavrospapadopoulos
approved these changes
Aug 11, 2020
This disables TBB by default in the bootstrap script. Using our `/test/benchmarking` benchmarks, there is no discernible difference between the end-to-end execution times or the individual execution times of the parallel functions. For example, here is are the results of the `bench_large_io` between the two: // Without TBB end-to-end: 267829 ms `parallel_for`: 271120 ms `parallel_for_2d`: 104 ms `parallel_sort`: 14447 ms // With TBB end-to-end: 269911 ms `parallel_for`: 273447 ms `parallel_for_2d`: 107 ms `parallel_sort`: 14382 ms Note that the "end-to-end" was measured with a different timing mechanism than the individual function timers. The individual function timers are also cumulative per thread.
joe-maley
force-pushed
the
jpm/disable-tbb
branch
from
August 11, 2020 10:53
dd8e8b9 to
eed065f
Compare
Shelnutt2
approved these changes
Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables TBB by default in the bootstrap script.
Using our
/test/benchmarkingbenchmarks, there is no discernible differencebetween the end-to-end execution times or the individual execution times of the
parallel functions. For example, here is are the results of the
bench_large_iobetween the two:
// Without TBB
end-to-end: 267829 ms
parallel_for: 271120 msparallel_for_2d: 104 msparallel_sort: 14447 ms// With TBB
end-to-end: 269911 ms
parallel_for: 273447 msparallel_for_2d: 107 msparallel_sort: 14382 msNote that the "end-to-end" was measured with a different timing mechanism than
the individual function timers. The individual function timers are also
cumulative per thread.