Conversation
Directories need the executable bit set, so finer control is given by splitting the posix permission config into one for files and one for directories.
Shelnutt2
force-pushed
the
sethshelnutt/ch2722/split-posix-permissions-for-files-and-directories
branch
from
July 10, 2020 16:07
d3a4e78 to
97fd61d
Compare
ihnorton
approved these changes
Jul 10, 2020
ihnorton
left a comment
Contributor
There was a problem hiding this comment.
The parameter split seems ok to me. 👍
Shelnutt2
deleted the
sethshelnutt/ch2722/split-posix-permissions-for-files-and-directories
branch
July 13, 2020 18:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directories need the executable bit set, so finer control is given by splitting the posix permission config into one for files and one for directories. This allows files to be created without the executable bit.
This is, in a way a breaking change since I've removed the old configuration option. I thought best to remove the ambiguous option and force the new specific options. I can however adjust the PR to leave the old option, and add the new directory one only, if there is consensus. Note: the break is only if a user was manually overriding the default config value introduced in 2.0.6. If the user was not overriding, there is no breakage.