Implement seek function for curl posts - #1728
Merged
Shelnutt2 merged 1 commit intoJul 20, 2020
Merged
Conversation
joe-maley
approved these changes
Jul 18, 2020
joe-maley
left a comment
Contributor
There was a problem hiding this comment.
LGTM, a few style nitpicks
Shelnutt2
force-pushed
the
sethshelnutt/ch879/need-to-implement-curlopt-seekfunction-for
branch
from
July 18, 2020 19:02
a69044d to
766c178
Compare
This allows for redirects to be successful in POSTing data from curl over REST. A new `BufferList::seek(offset, whence)` function was added to facilitate this.
Shelnutt2
force-pushed
the
sethshelnutt/ch879/need-to-implement-curlopt-seekfunction-for
branch
from
July 18, 2020 19:03
766c178 to
15a6fc5
Compare
Shelnutt2
deleted the
sethshelnutt/ch879/need-to-implement-curlopt-seekfunction-for
branch
July 20, 2020 11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for redirects to be successful in POSTing data from curl over REST. A new
BufferList::seek(offset, whence)function was added to facilitate this.