Extra offset element in partial reads (Arrow compatibility) - #1970
Merged
Merged
Conversation
ypatia
force-pushed
the
yt/3891_extra_offset_in_partial_reads
branch
from
December 24, 2020 16:35
06fa3b8 to
2b25f3b
Compare
ypatia
requested review from
Shelnutt2,
bekadavis9,
joe-maley,
ktsitsi and
stavrospapadopoulos
December 24, 2020 16:36
Base automatically changed from
yt/3892_extra_element_offset_write_path
to
dev
December 28, 2020 15:55
joe-maley
force-pushed
the
yt/3891_extra_offset_in_partial_reads
branch
from
December 28, 2020 16:19
2b25f3b to
577da82
Compare
joe-maley
reviewed
Dec 28, 2020
joe-maley
approved these changes
Dec 28, 2020
joe-maley
left a comment
Contributor
There was a problem hiding this comment.
Great patch! This approach is much cleaner than the one I was envisioning. Great job. I left one minor test comment, but this LGTM otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is an attempt to address the scenario that was not supported so far, where the user has enabled the usage of an extra element in the offset buffer (which indicates the size/length of data to be written), but the offsets buffer she has provided doesn't have space for the extra element.
This is a generic problem we solve today by partitioning the read ranges so that the results do not exceed the user's buffer sizes, so to support this we just make the subarray partitioner aware of the need for this extra element.
I have tried to address it with minimal changes, but I am not sure I fully understand the requirements, so please check the testcases I modified to confirm/correct my understanding.