Exit early in copy_attribute_values when empty res - #1984
Merged
Shelnutt2 merged 1 commit intoDec 30, 2020
Merged
Conversation
joe-maley
reviewed
Dec 30, 2020
Shelnutt2
force-pushed
the
ss/copy_attribute_values-exit-early-when-no-results
branch
from
December 30, 2020 01:47
9d3b82e to
9a2f80c
Compare
stavrospapadopoulos
approved these changes
Dec 30, 2020
Shelnutt2
force-pushed
the
ss/copy_attribute_values-exit-early-when-no-results
branch
from
December 30, 2020 13:04
9a2f80c to
a10a68e
Compare
In copy_coordinates/copy_attribute_values we do not exit early when there is no results, so we end up calling load_tile_offsets et al unnecessarily. This changes adds a check to exit early on empty result_cell_slabs or result_tiles.
Shelnutt2
force-pushed
the
ss/copy_attribute_values-exit-early-when-no-results
branch
from
December 30, 2020 14:21
a10a68e to
165b692
Compare
joe-maley
approved these changes
Dec 30, 2020
Shelnutt2
deleted the
ss/copy_attribute_values-exit-early-when-no-results
branch
December 30, 2020 15:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Reader::copy_attribute_valueswe do not exit early when there is no results, so we end up callingReader::load_tile_offsetset al unnecessarily. This change can improve performance of the no-results case and avoid unnecessary VFS reads.