Consolidation/vacuum should use ctx if config null - #2126
Merged
Shelnutt2 merged 1 commit intoMar 12, 2021
Merged
Conversation
|
This pull request has been linked to Clubhouse Story #5806: c-api consolidate doesn't use ctx config. |
joe-maley
approved these changes
Mar 12, 2021
Shelnutt2
force-pushed
the
sethshelnutt/ch5806/c-api-consolidate-doesn-t-use-ctx-config
branch
from
March 12, 2021 15:55
f197ced to
808e047
Compare
stavrospapadopoulos
approved these changes
Mar 12, 2021
If the user only passes a ctx and not a config we should use the config from the ctx object for the consolidation and vacuum functions.
Shelnutt2
force-pushed
the
sethshelnutt/ch5806/c-api-consolidate-doesn-t-use-ctx-config
branch
from
March 12, 2021 17:55
808e047 to
13a7ab6
Compare
Shelnutt2
deleted the
sethshelnutt/ch5806/c-api-consolidate-doesn-t-use-ctx-config
branch
March 12, 2021 22:38
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.2 release-2.2
# Navigate to the new working tree
cd .worktrees/backport-release-2.2
# Create a new branch
git switch --create backport-2126-to-release-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 880c7a0bef1d986a05764b4450c301c1e54d293d
# Push it to GitHub
git push --set-upstream origin backport-2126-to-release-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.2Then, create a pull request where the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user only passes a ctx and not a config we should use the config from the ctx object for the consolidation and vacuum functions.
TYPE: BUG
DESC: Consolidate and vacuum will now correctly use the ctx's config if no config is passed directly.