fix(ToneConstantSource): preserve delayed start time#1458
Open
whizzkid1452 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1458 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 209 209
Lines 23529 23531 +2
Branches 1045 1047 +2
=======================================
+ Hits 23281 23284 +3
+ Misses 247 246 -1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToneConstantSourcestart time when the nativeConstantSourceNodeis created after a suspendedAudioContextresumes.Test plan
npx prettier --write Tone\signal\ToneConstantSource.ts Tone\signal\ToneConstantSource.test.tsnpx tscnpx eslint Tone\signal\ToneConstantSource.ts Tone\signal\ToneConstantSource.test.tsnpx web-test-runner --config=./test/web-test-runner.config.js --coverage --group signal