Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing CI builds the
cudaandcuda-thrustmodels but does not run them (skip_run: true, no GPU on the runners), so the ctestsolutioncase is never run on those models. This adds a separate, optional workflow.github/workflows/gpu-sim.ymlthat builds both and runssolution(bm1, 1024 poses, energies checked against the deck) on a simulated NVIDIA H100 using PantheonSim (no GPU needed). I am the author of PantheonSim, so please weigh this accordingly.It touches no source file, does not change
linux.ymland is not meant to be a required check. A simulator cannot reproduce hardware-specific behavior or timing, so it complements real-GPU testing and does not replace it.What it does:
cudamodel with-DCUDA_ARCH=sm_90and thethrustmodel with-DTHRUST_IMPL=CUDA -DBACKEND=CUDA -DCUDA_ARCH=90-virtual, both with-DCUDA_EXTRA_FLAGS="-cudart shared". The simulator runs PTX and needs a shared CUDA runtime. The thrust model passesCUDA_ARCHstraight toCMAKE_CUDA_ARCHITECTURES, so it needs the-virtualform; for the cuda modelsm_90also embeds PTXvgpu run ctest -L solutionfor eachmainthat touchsrc/cuda,src/thrust,src/main.cpp,src/bude.h,data,cmakeorCMakeLists.txt, with a concurrency group that cancels superseded runsMeasured:
solution) each.solutiontest took 33 seconds in the cuda job.max_diff_% 0.002for the cuda model (0.001 for thrust), the same as an RTX 3060 for the cuda model.Not covered:
solutioncase defaults) are run, not the other PPWI values.