Skip to content

fix: restore explicit allow-all with recipient glob patterns - #250

Merged
Wh1isper merged 1 commit into
mainfrom
fix/recipient-glob-allowlist
Sep 7, 2026
Merged

Wh1isper merged 1 commit into
mainfrom
fix/recipient-glob-allowlist

Conversation

@Wh1isper

@Wh1isper Wh1isper commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

Follow up on #247 (comment).

  • Preserve the deny-all semantics for an empty recipient allowlist introduced by fix: deny recipient-bound operations for empty allowlists #248.
  • Support explicit case-insensitive recipient globs: * / *@* for all valid recipients, domain patterns such as *@example.com, and ? / bracket expressions.
  • Preserve glob syntax across managed CLI/UI, legacy TOML/environment, persistence, and import, while retaining exact display-name address normalization.
  • Apply the shared policy to send, forward, and recipient-bound mailbox saves, including To/CC/BCC and existing validation/current-authority checks.
  • Update CLI/UI guidance, MCP discovery and catalog snapshot, documentation/specs, and staged frontend assets.

Compatibility

This restores an explicit opt-in for dynamic-recipient workflows; it does not restore implicit allow-all for an empty list. A wildcard authorizes all three operations, not drafts only. Existing entries containing glob syntax now act as patterns.

Validation

  • make check
  • make test: 1506 passed, 37 skipped; 87.41% coverage
  • make docs-test
  • make test-e2e: 12 passed against GreenMail, including explicit wildcard send/forward/save and live managed-policy changes
  • make frontend: lint/typecheck, 41 frontend tests, staged asset verification
  • make test-browser: 2 passed
  • Independent focused authorization review: no findings

Planned release: 1.9.0, after CI passes and merge.

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.6%. Comparing base (b8fe19f) to head (fde9667).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #250   +/-   ##
=====================================
  Coverage   84.6%   84.6%           
=====================================
  Files         31      31           
  Lines       9229    9229           
  Branches    1297    1297           
=====================================
  Hits        7810    7810           
  Misses       988     988           
  Partials     431     431           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Wh1isper
Wh1isper merged commit 72e2605 into main Sep 7, 2026
17 checks passed
alonsoac pushed a commit to PBX-Virtual/mcp-email-server that referenced this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant