Skip to content

Restore has arcane soul flag in onBoltApply - #8091

Open
ardeaf wants to merge 1 commit into
WoWAnalyzer:midnightfrom
ardeaf:patch-1
Open

ardeaf wants to merge 1 commit into
WoWAnalyzer:midnightfrom
ardeaf:patch-1

Conversation

@ardeaf

@ardeaf ardeaf commented Sep 11, 2026

Copy link
Copy Markdown

Description

Munched procs during soul are no longer being tracked after the latest changes tracking pbolt casts. This is simply restoring the has arcane soul flag in the on apply buff section.

Testing

  • Test report URL: https://www.warcraftlogs.com/reports/yaqcXnkPfAb2967Q/?fight=26&source=1&type=auras&view=events&ability=451038

  • Screenshot(s):

Screenshot_20260910_211534_Brave Screenshot_20260910_211414_Brave

@Sharrq

Sharrq commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

I can merge this, but you would have to fix the lint error and add a changelog entry to pass the checks

Otherwise I'll fix it myself separately.

@ardeaf

ardeaf commented Sep 11, 2026

Copy link
Copy Markdown
Author

Otherwise I'll fix it myself separately.

Please, PC just died yesterday so I can't get a local environment up and running at the moment to run the lint fix.

@Sharrq Sharrq closed this Sep 15, 2026
@Sharrq Sharrq reopened this Sep 15, 2026
@Sharrq

Sharrq commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Reopened it to get the checks to run again

@Sharrq

Sharrq commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Actually, just noticed that the existing module already does check for arcane soul on the cast. So this is adding a duplicate arcane soul check. I'll have to look to see what you are describing in your log and see if there is someone else broken about it

@Sharrq

Sharrq commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Actually actually, nevermind I'm dumb

It needs to not check on the cast, it needs to check on the apply/refresh exactly like you have listed here. This needs to go a step further though and remove it from the cast event. I'll do it when I get home from blizzcon

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants