Skip to content

[m3msg] Remove data race - #4160

Merged
vdarulis merged 1 commit into
masterfrom
v/m3msg_data_race
Oct 13, 2022
Merged

vdarulis merged 1 commit into
masterfrom
v/m3msg_data_race

Conversation

@vdarulis

@vdarulis vdarulis commented Oct 13, 2022 •

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

The race itself is fixed at the root in #4114 - however that PR still isn't ready yet, and this is Good Enough (tm) for now.

It hasn't been a problem in practice, however tests with -race complain. Also we should fix the tests to actually run with -race.

Does this PR require updating code package or user-facing documentation?:


@andrewmains12 andrewmains12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm; the memory leak afaik was mostly theoretical anyways (though worth fixing overall). I'll file a task to revisit whenever we get a chance.

@vdarulis
vdarulis merged commit 764f601 into master Oct 13, 2022
@vdarulis
vdarulis deleted the v/m3msg_data_race branch October 13, 2022 12:34
andrewmains12 pushed a commit that referenced this pull request Oct 18, 2022
andrewmains12 added a commit that referenced this pull request Oct 18, 2022
Co-authored-by: Vytenis Darulis <vytenis@uber.com>
safa-topal pushed a commit to aiven/m3 that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants