Skip to content

[m3aggregator/client] Add metrics around bytes emissions - #4300

Merged
rahultejwani merged 8 commits into
masterfrom
add_bytes_metrics
Oct 3, 2024
Merged

rahultejwani merged 8 commits into
masterfrom
add_bytes_metrics

Conversation

@rahultejwani

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Adding metrics to keep track of total bytes sent from the tcp_client
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@prateek prateek changed the title Add bytes metrics [m3aggregator/client] Add metrics around bytes emissions Oct 2, 2024
@rahultejwani
rahultejwani merged commit 771ab81 into master Oct 3, 2024
@rahultejwani
rahultejwani deleted the add_bytes_metrics branch October 3, 2024 17:27
adamjeanlaurent pushed a commit that referenced this pull request Aug 24, 2025
* Add totalBytesSent metric to tcp_client

* Add bytesAdded to writer

* remove defer() to not hinder inlining

* Fix failing test

* Remove all the defer() calls and optimize calling of encoder.len()

* Remove optimization to revert back the read-lock

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants