Repository navigation
[dbnode] Rename embed.Config URL fields, bump etcd to 3.5.8 - #4407
Merged
Merged
Conversation
justinhwang
force-pushed
the
justinhwang/etcd-embed-field-rename
branch
2 times, most recently
from
September 16, 2026 17:31
ccffe30 to
8fee6ed
Compare
etcd renamed embed.Config's LPUrls/LCUrls/APUrls/ACUrls fields to ListenPeerUrls/ListenClientUrls/AdvertisePeerUrls/AdvertiseClientUrls in v3.5.8 (a breaking rename with no aliases). Master currently pins etcd 3.5.5 and uses the old names, which means m3 fails to compile against any etcd >= 3.5.8 forced by a downstream replace directive. Bump to 3.5.8 specifically: 3.5.14+ requires grpc >= 1.59 and protobuf >= 1.33, which drags the module graph past otel v1.4.1 and breaks m3's opentelemetry-collector usage (otel/metric/global was removed from newer otel releases). 3.5.8 requires only grpc 1.41, so nothing else in the graph moves. Also drop the stale etcd comment above the require block. It claimed etcd was pinned to an alpha to accommodate a gRPC upgrade and described a 3.5.2 vs opentelemetry conflict; m3 has been on stable 3.5.x for some time, so none of it still applies. The followup it referenced, #4090 (update etcd past 3.6.0-alpha.0 once stable), is still open and tracked there. The gopkg.in/yaml.v3 indirect requirement is now dropped by go mod tidy: etcd 3.5.8, bbolt 1.3.7, etcd/pkg/v3 and etcd/client/pkg/v3 each require yaml.v3 v3.0.1 themselves, so the explicit entry is redundant. Selected version is unchanged at v3.0.1. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
justinhwang
force-pushed
the
justinhwang/etcd-embed-field-rename
branch
from
September 16, 2026 21:55
8fee6ed to
a3d4030
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes compilation against etcd >= 3.5.8. etcd renamed
embed.Config'sLPUrls/LCUrls/APUrls/ACUrlsfields toListenPeerUrls/ListenClientUrls/AdvertisePeerUrls/AdvertiseClientUrlsin v3.5.8, a breaking rename with no aliases. Master pins etcd 3.5.5 and uses the old names inNewEtcdEmbedConfig(src/cmd/services/m3dbnode/config/config.go), so any downstream consumer whose module graph forces etcd server v3.5.8+ (for example via a replace directive) cannot compile m3.This reopens #4404 from a branch on this repository rather than a fork, rebased onto current master.
Special notes for your reviewer:
go.opentelemetry.io/otel/metric/globalwas removed from newer otel releases, sogo mod tidyfails). 3.5.8 requires only grpc 1.41, so nothing else in the module graph moves. Going further is a separate otel-modernization effort.go.moddiff is confined to the etcd bump and its MVS consequences: bbolt 1.3.6 to 1.3.7,golang.org/x/net0.1.0 to 0.7.0,golang.org/x/sys0.1.0 to 0.5.0,golang.org/x/text0.4.0 to 0.7.0, andform3tech-oss/jwt-goreplaced bygolang-jwt/jwt/v4v4.4.2 (etcd 3.5.8 switched JWT libraries).src/cmd/services/m3dbnode/...andsrc/dbnode/server/..., andsrc/cmd/services/m3dbnode/configtests pass.Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: