Paramaterize Prometheus integration test to use for local testing - #928
Merged
robskillington merged 2 commits intoSep 21, 2018
Merged
Conversation
nerd0
approved these changes
Sep 21, 2018
| mkdir -p /tmp/m3dbdata/ | ||
|
|
||
| echo "Build docker images" | ||
| PARAM_TEST_BUILD="${TEST_BUILD:-true}" |
Contributor
There was a problem hiding this comment.
Are these injected by semaphore? Or just more meant for local testing?
Collaborator
Author
There was a problem hiding this comment.
Local testing yeah.
| image: prom/prometheus:latest | ||
| volumes: | ||
| - "./:/etc/prometheus/" | ||
| grafana: |
Contributor
There was a problem hiding this comment.
Just curious if grafana used within the test?
Collaborator
Author
There was a problem hiding this comment.
It is not, we're going to be using this as a hack to run this locally heh.
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
- Coverage 78.67% 78.64% -0.04%
==========================================
Files 406 406
Lines 34319 34319
==========================================
- Hits 27000 26989 -11
- Misses 5473 5479 +6
- Partials 1846 1851 +5
Continue to review full report at Codecov.
|
robskillington
deleted the
r/parameterize-prometheus-integration-test
branch
September 21, 2018 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.