Fix a bug in iterator deduplication logic - #984
Closed
arnikola wants to merge 1 commit into
Closed
Conversation
| dedupeMap map[string]multiFetchResultSeries | ||
| iterators encoding.SeriesIterators | ||
| err xerrors.MultiError | ||
| dedupeFirstResolution time.Duration |
Collaborator
There was a problem hiding this comment.
Is there a major reason to change to resolution time.Duration instead of attrs storage.Attributes? They are both value types that shouldn't be able to be nil'd.
It's just I have an open PR that depends on having access to the attributes rather than just the resolution:
#908
Collaborator
Author
There was a problem hiding this comment.
Sure, changed it since we were only using the resolution
Collaborator
|
@arnikola need to rebase, master was broken until a little bit ago |
prateek
reviewed
Sep 29, 2018
| err xerrors.MultiError | ||
| dedupeFirstAttrs storage.Attributes | ||
| dedupeMap map[string]multiFetchResultSeries | ||
| iterators encoding.SeriesIterators |
Collaborator
There was a problem hiding this comment.
could you add test(s) to repro the bug fix
|
|
||
| iters := iterators.Iters() | ||
| // Need to dedupe | ||
| iters := r.iterators.Iters() |
Collaborator
There was a problem hiding this comment.
Ah this was the bug?
Collaborator
Author
There was a problem hiding this comment.
Yeah, bad refactor somewhere along the line
Collaborator
|
addressed in #989 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.