Skip to content

Fix issue #72 - #74

Merged
lamoreel merged 1 commit into
devfrom
issue-72
Apr 28, 2025
Merged

Fix issue #72#74
lamoreel merged 1 commit into
devfrom
issue-72

Conversation

@lamoreel

Copy link
Copy Markdown
Contributor

This PR closes issue #72.

@lamoreel lamoreel added the bug Something isn't working label Apr 25, 2025
@lamoreel
lamoreel requested a review from ilateur April 25, 2025 09:48
@lamoreel lamoreel self-assigned this Apr 25, 2025
@lamoreel lamoreel linked an issue Apr 25, 2025 that may be closed by this pull request
@lamoreel lamoreel changed the title Throw timestep error if rhs is zero Fix issue #72 Apr 25, 2025
@ilateur

ilateur commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

Should there be a test which expects the proper error? Similar to test_set_invalid_method in test_timesolver.py

@lamoreel

lamoreel commented Apr 28, 2025

Copy link
Copy Markdown
Contributor Author

Hmm, perhaps, although I think this might be overkill (it's a delicate interplay between magnets in World and its associated TimeSolver). Not every std::runtime_error is caught in a pytest test. However, if you want to, a timestep of zero could be added to test_set_invalid_timepoints in test_timesolver.py. Or, which might be even better, define a new function test_invalid_timestep which catches even more invalid values.

@lamoreel
lamoreel merged commit 87db99e into dev Apr 28, 2025
@lamoreel
lamoreel deleted the issue-72 branch April 28, 2025 09:11
lamoreel added a commit that referenced this pull request Apr 30, 2025
gyuyoungpark pushed a commit to gyuyoungpark/mumax-plus-extensions that referenced this pull request Mar 1, 2026
gyuyoungpark pushed a commit to gyuyoungpark/mumax-plus-extensions that referenced this pull request Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relax yields NaN when torque is exactly 0

2 participants