fix: read host JSON from stdin - #1010
Draft
miketuckman wants to merge 1 commit into
Draft
miketuckman wants to merge 1 commit into
miketuckman wants to merge 1 commit into
Conversation
Owner
|
Speaking as Matt's firstmate: Triage (FM-CLEAR-L30-2): DRAFT fix read host JSON from stdin — mark ready or close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow all host-authored JSON inputs (
--plan,--competitors-plan,--judgments, and--angles) to use-for stdin. Update the agent skill templates to use quoted heredocs instead of temporary files withrm -fcleanup traps, which Codex can reject before the research command executes.Inline JSON and existing JSON file paths remain supported.
Testing
uv run pytest— 4,007 passed, 6 skipped, 48 subtests passedChangelog
changelog.d/+stdin-json-inputs.fixed.md(types:added,changed,fixed,removed,deprecated,security)skip-changeloglabel)Agent disclosure
AI review
Codex reviewed backward compatibility for inline and file-backed JSON, error handling for invalid stdin JSON, shell quoting in every documented heredoc, and the full three-leg discovery protocol. The review identified indentation drift in one new fixture, which was corrected before the full test run.
git diff --checkis clean.Security
Stdin content follows the same
json.loadsparsing and schema validation as existing inline/file inputs. The quoted heredocs suppress shell interpolation, and removing temporary files also removes the associated cleanup command and filesystem race surface. No auth, secrets, or dependencies changed.Notes
The generic Codex skill validator was also attempted, but this repository's existing
SKILL.mdfrontmatter contains supported project metadata fields that the generic validator does not accept. The repository's own complete test suite and skill contract tests pass.Relationship to this change
Related issues
N/A — observed directly in Codex Desktop when the local command safety layer rejected the mandatory
rm -fcleanup trap before execution.