Repository navigation
Conversation
Owner
|
Thank you again for the thoughtful work, and especially for patiently splitting the Windows Terminal focus changes into a dedicated experimental PR. I’ve now merged #16 into Sorry this took me a while — work has been especially busy recently, so I wasn’t able to review and handle the PR as promptly as I should have. I really appreciate your patience and your continued contributions to LLMPET. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This PR contains only the Windows Terminal session-focus work split from #15 and targets the maintainer's
experimental/windows-terminal-focusbranch.wt.exe, create a tab, or resume a CLI.Acceptance-point changes
perMachineor change the release version.WT_SESSION. Background tool hooks reuse the correlated route and cannot cache an arbitrary foreground tab.Validation
npm testpasses on Windows (including protocol input restrictions, disconnect/reconnect, foreground-correlation, cache restoration, missing/closed-tab behavior, and the no-per-click-RunAsguarantee).CI=true; it checks the resolved user SID,RunLevel=Limited, interactive logon type, and fixed launcher action.scripts/validate-windows-terminal-focus.ps1produces JSONL evidence for installer, launcher, broker, task lifecycle, reconnect tests, and correlation; optional window/runtime/PID arguments reproduce live exact-tab focus.No version bump or generated release artifact is included.