Remove netCDF from mass detection step #1141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oh there are more problems with this. |
Member
Author
|
@asmirn1, can you comment on this? We would like to remove the option from mass detection as an export does not belong with the fundamental data processing step |
Collaborator
|
@robinschmid I agree that the netCDF export isn't needed in the preprocessing step. I can remove it and make a merge request if you want me to. |
Member
|
Thanks for confirming @asmirn1! No need to make an other PR. Would be great if you could review this one. |
Collaborator
|
The code looks good to me. |
ansgarkorf
reviewed
Dec 19, 2023
src/main/java/io/github/mzmine/modules/io/export_rawdata_netcdf/NetCDFExportTask.java
Outdated
Show resolved
Hide resolved
…t_mass_detect # Conflicts: # src/main/java/io/github/mzmine/modules/dataprocessing/featdet_massdetection/MassDetectionParameters.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tomas-pluskal @asmirn1
Can you confirm that we can remove this option?
This PR removes the option to export netCDF right after mass detection. People should use the module instead.
However we would need to enable that people can export mass lists instead of the original raw data in the module.