Add CLI argument to change files easily #1336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteffenHeu
requested changes
May 11, 2023
Member
SteffenHeu
left a comment
There was a problem hiding this comment.
looks good, but some comments
| } | ||
|
|
||
| if (overrideDataFiles != null) { | ||
| if (!newQueue.setImportFiles(overrideDataFiles)) { |
Member
There was a problem hiding this comment.
the method never returns false but throws an exception instead, so the code below is never reached.
Member
Author
There was a problem hiding this comment.
returns false now. Logging was improved and jdocs as well
| * | ||
| * @param allFiles replaces import files | ||
| */ | ||
| public boolean setImportFiles(final File[] allFiles) { |
Member
There was a problem hiding this comment.
does not return false but throws an exception. Refactor to do one of the two.
Member
Author
There was a problem hiding this comment.
returns false now. Logging was improved and jdocs as well
SteffenHeu
approved these changes
May 19, 2023
Member
|
looks good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added arguments i: input to change the input files in batch files easily. It just replaces all the files in the AllSpectralDataImportModule.
Either provide a txt file with paths or use glob patterns