Skip to content

move thermo parser extraction path, add to tmp file cleanup #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robinschmid merged 1 commit into from
Apr 25, 2024
Merged

move thermo parser extraction path, add to tmp file cleanup #1816

robinschmid merged 1 commit into from
Apr 25, 2024

Conversation

@SteffenHeu
Copy link
Member

@SteffenHeu SteffenHeu commented Apr 25, 2024

Thermo parser was still extracted to system temp dir. Added to temp file cleanup.

@SteffenHeu SteffenHeu requested a review from robinschmid April 25, 2024 07:45
@robinschmid
Copy link
Member

robinschmid commented Apr 25, 2024

Looks good.
There is also this try at improving it:
#811

But there were issues with macOS

robinschmid
robinschmid approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@robinschmid robinschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@robinschmid robinschmid merged commit 4edd352 into mzmine:master Apr 25, 2024
@SteffenHeu SteffenHeu deleted the thermo-import branch April 25, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robinschmid robinschmid robinschmid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SteffenHeu @robinschmid