IMS mzML import - memory map early and reduce memory overhead during import #1849
Conversation
last missing piece is the MobilityScanStorage
mzmine-community/src/main/java/io/github/mzmine/datamodel/impl/MobilityScanStorage.java
Show resolved
Hide resolved
|
|
||
| description = descriptionTemplate + convertedScansAfterFilter; | ||
| } | ||
| if (mobilityType == MobilityType.TIMS && mobilities[0] - mobilities[1] < 0) { |
There was a problem hiding this comment.
i cant see where the mobilities[] comes from, but in tdf tims files there can be multiple mobility segements. I think for the parsing from mzml its fine if we have just one segment and add additional mobility scans to all frames
There was a problem hiding this comment.
This is the same logic like before just removed from the total loop and put outside of the loop
| return realMobilities; | ||
| } | ||
|
|
||
| private static boolean isExcludedWatersScan(final BuildingMzMLMobilityScan mzMLScan) { |
There was a problem hiding this comment.
what does this method match?
There was a problem hiding this comment.
Excludes waters frame I think.
| } | ||
|
|
||
| // apply mass detection to frames and mobility scans | ||
| // apply mass detection to frames NOT to mobility scans |
There was a problem hiding this comment.
should we also apply to mobility scans? that would reproduce the ims tdf import
There was a problem hiding this comment.
I changed the message and added more documentation to this.
Mass detection is done on mobility scans but not on frames because we do not have frames
No description provided.